angular/packages/core/src/render3
Igor Minar 3961b3c360 fix(core): ensure that autoRegisterModuleById registration in ɵɵdefineNgModule is not DCE-ed by closure (#42529)
Previously the autoRegisterModuleById registration was marked with noSideEffects wrapper to ensure that we don't end up retaining all NgModules.

However the return value was not referenced by anything, so closure compiler removed it because it determined that this code has no side effects and is not referenced by anyone.

This issue affects apps that use Closure Compiler and also rely on https://angular.io/api/core/getModuleFactory to retrieve factories by ID. This combination is used heavily in google3, especially in Pantheon.

Fixes b/188453434

PR Close #42529
2021-06-09 12:13:23 -07:00
..
features fix(core): remove duplicated EMPTY_OBJ constant (#41066) 2021-03-04 11:08:49 -08:00
i18n fix(core): handle multiple i18n attributes with expression bindings (#41882) 2021-04-30 14:20:15 -07:00
instructions fix(core): global listeners not being bound on non-node host elements (#42014) 2021-05-14 14:51:04 +00:00
interfaces perf(core): minor improvements to listener instructions (#41807) 2021-04-30 14:14:00 -07:00
jit fix(core): do not retain dynamically compiled components and modules (#42003) 2021-05-10 10:36:21 -04:00
styling docs(core): fix typo (#39041) 2020-09-30 09:32:15 -04:00
util docs: convert the last my-app components to app-root (#42256) 2021-05-25 22:13:36 +00:00
assert.ts fix(core): properly move embedded views of dynamic component's projectable nodes (#37167) 2021-02-10 11:03:06 -08:00
bindings.ts refactor(core): renames checkNoChangesMode to be clearer (#39277) 2020-10-15 17:01:20 -07:00
CODE_GEN_API.md refactor(ivy): Move instructions back to ɵɵ (#30546) 2019-05-20 16:37:47 -07:00
collect_native_nodes.ts fix(core): properly move embedded views of dynamic component's projectable nodes (#37167) 2021-02-10 11:03:06 -08:00
component.ts refactor(core): co-locate read/write patched data functions (#41097) 2021-03-08 08:38:00 -08:00
component_ref.ts refactor(core): add single type for injector token (#41580) 2021-04-22 10:47:12 -07:00
context_discovery.ts Revert "perf(core): avoid storing LView in __ngContext__ (#41358)" (#41901) 2021-04-30 14:12:52 -07:00
definition.ts fix(core): ensure that autoRegisterModuleById registration in ɵɵdefineNgModule is not DCE-ed by closure (#42529) 2021-06-09 12:13:23 -07:00
definition_factory.ts refactor(compiler): move factory out of injector definition (#41022) 2021-03-08 15:31:30 -08:00
di.ts refactor(core): add single type for injector token (#41580) 2021-04-22 10:47:12 -07:00
di_setup.ts refactor(core): renamed previousOrParent to currentTNode (#38707) 2020-09-28 16:15:59 -04:00
error_code.ts refactor(common): change missing NgSwitch provider error message (#41704) 2021-05-06 15:44:38 -04:00
errors.ts refactor(core): use unknown rather than never for private properties (#41040) 2021-03-04 11:04:26 -08:00
errors_di.ts refactor(core): clean up circular dependencies (#39722) 2020-11-18 09:15:29 -08:00
fields.ts build: update license headers to reference Google LLC (#37205) 2020-05-26 14:26:58 -04:00
global_utils_api.ts feat(core): introduce getDirectiveMetadata global debugging utility (#41525) 2021-04-13 16:06:32 -07:00
hooks.ts perf(core): add private hooks around user code executed by the runtime (#41255) 2021-04-02 10:34:23 -07:00
index.ts feat(core): introduce getDirectiveMetadata global debugging utility (#41525) 2021-04-13 16:06:32 -07:00
metadata.ts refactor(compiler-cli): use ngDevMode guard for setClassMetadata call (#39987) 2020-12-10 13:23:13 -08:00
namespaces.ts build: update license headers to reference Google LLC (#37205) 2020-05-26 14:26:58 -04:00
ng_module_ref.ts refactor(core): Remove circular dependency on render3 and ng_module (#39621) 2020-11-16 09:12:46 -08:00
node_assert.ts ci: add lint error for files with missing trailing new-line (#42478) 2021-06-04 13:31:03 -07:00
node_manipulation.ts fix(core): invoke profiler around ngOnDestroy lifecycle hooks (#41969) 2021-05-07 10:04:21 -04:00
node_manipulation_i18n.ts refactor(core): clean up circular dependencies (#39722) 2020-11-18 09:15:29 -08:00
node_selector_matcher.ts refactor(core): Change TName.tagName to a more generic value name. (#39233) 2020-10-21 18:33:00 -07:00
PERF_NOTES.md docs: update links to use HTTPS as protocol (#39718) 2020-11-20 12:52:16 -08:00
pipe.ts refactor(core): clean up circular dependencies (#39722) 2020-11-18 09:15:29 -08:00
profiler.ts perf(core): add private hooks around user code executed by the runtime (#41255) 2021-04-02 10:34:23 -07:00
pure_function.ts fix(core): Store the currently selected ICU in LView (#38345) 2020-08-10 12:41:17 -07:00
query.ts refactor(core): add single type for injector token (#41580) 2021-04-22 10:47:12 -07:00
state.ts refactor(compiler): retrieve variables from context inside nested template listener (#40833) 2021-02-17 11:45:46 -08:00
STATUS.md docs: changes AoT to AOT for consistency (#35112) 2020-02-04 10:43:33 -08:00
STORING_METADATA_IN_D.TS.md docs: convert the last my-app components to app-root (#42256) 2021-05-25 22:13:36 +00:00
tokens.ts build: update license headers to reference Google LLC (#37205) 2020-05-26 14:26:58 -04:00
TREE_SHAKING.md docs(ivy): add feature principle doc (#21565) 2018-01-17 17:01:09 -08:00
VIEW_DATA.md refactor(core): Replace ExpandoInstructions with HostBindingOpCodes (#39301) 2020-10-22 09:35:48 -07:00
view_engine_compatibility_prebound.ts refactor(core): remove the need for ɵɵinjectPipeChangeDetectorRef() (#41231) 2021-03-30 16:46:37 -07:00
view_ref.ts docs: convert the last my-app components to app-root (#42256) 2021-05-25 22:13:36 +00:00