angular/packages/compiler-cli/ngcc/test
JoostK 18098d38b8 fix(compiler-cli): avoid creating value expressions for symbols from type-only imports (#37912)
In TypeScript 3.8 support was added for type-only imports, which only brings in
the symbol as a type, not their value. The Angular compiler did not yet take
the type-only keyword into account when representing symbols in type positions
as value expressions. The class metadata that the compiler emits would include
the value expression for its parameter types, generating actual imports as
necessary. For type-only imports this should not be done, as it introduces an
actual import of the module that was originally just a type-only import.

This commit lets the compiler deal with type-only imports specially, preventing
a value expression from being created.

Fixes #37900

PR Close #37912
2020-08-11 09:53:25 -07:00
..
analysis refactor(ngcc): let isWithinPackage operate on paths instead of source files (#37596) 2020-06-29 12:21:22 -07:00
dependencies refactor(ngcc): move logging code into ngtsc (#37114) 2020-06-22 13:38:47 -07:00
entry_point_finder perf(ngcc): use EntryPointManifest to speed up noop ProgramBaseEntryPointFinder (#37665) 2020-06-25 14:11:03 -07:00
execution fix(ngcc): ensure lockfile is removed when analyzeFn fails (#37739) 2020-06-29 10:29:11 -07:00
helpers fix(ngcc): prevent including JavaScript sources outside of the package (#37596) 2020-06-29 12:21:22 -07:00
host fix(compiler-cli): avoid creating value expressions for symbols from type-only imports (#37912) 2020-08-11 09:53:25 -07:00
integration fix(ngcc): prevent including JavaScript sources outside of the package (#37596) 2020-06-29 12:21:22 -07:00
locking refactor(ngcc): move logging code into ngtsc (#37114) 2020-06-22 13:38:47 -07:00
migrations refactor(ngcc): move logging code into ngtsc (#37114) 2020-06-22 13:38:47 -07:00
packages fix(ngcc): prevent including JavaScript sources outside of the package (#37596) 2020-06-29 12:21:22 -07:00
rendering refactor(ngcc): move logging code into ngtsc (#37114) 2020-06-22 13:38:47 -07:00
writing docs(ngcc): add additional next steps to an error (#37672) 2020-06-25 11:37:43 -07:00
BUILD.bazel refactor(ngcc): move logging code into ngtsc (#37114) 2020-06-22 13:38:47 -07:00
ngcc_options_spec.ts fix(ngcc): report a warning if ngcc tries to use a solution-style tsconfig (#38003) 2020-07-14 13:21:31 -07:00
utils_spec.ts build: update license headers to reference Google LLC (#37205) 2020-05-26 14:26:58 -04:00