mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
fd51e01335
This commit fixes a bug in View Engine whereby the compiler errorneously
thinks that a method of a component has decorator metadata when that
method is one of those in `Object.prototype`, for example `toString`.
This bug is discovered in v10.0.4 of `@angular/language-service` after
the default bundle format was switched from ES5 to ES2015.
ES5 output:
```js
if (propMetadata[propName]) {
decorators.push.apply(decorators, __spread(propMetadata[propName]));
}
```
ES2015 output:
```js
if (propMetadata[propName]) {
decorators.push(...propMetadata[propName]);
}
```
The bug was not discovered in ES5 because the polyfill for the spread
operator happily accepts parameters that do not have the `iterable`
symbol:
```js
function __spread() {
for (var ar = [], i = 0; i < arguments.length; i++)
ar = ar.concat(__read(arguments[i]));
return ar;
}
```
whereas in es2015 it’ll fail since the iterable symbol is not present in
`propMetadata['toString']` which evaluates to a function.
Fixes https://github.com/angular/vscode-ng-language-service/issues/859
PR Close #38292
|
||
|---|---|---|
| .. | ||
| compiler_spec.ts | ||
| jit_summaries_spec.ts | ||
| README.md | ||
| regression_spec.ts | ||
| static_reflector_spec.ts | ||
| static_symbol_resolver_spec.ts | ||
| summary_resolver_spec.ts | ||
| summary_serializer_spec.ts | ||
| test_util.ts | ||
Tests in this directory are excluded from running in the browser and only run in node.