angular/tslint.json
Paul Gschwendtner acf98268f8 refactor: update language-service package and tests to work with ESM (#48521)
The Angular Language Service package is now tested & compiled using ESM.
Previously it was a mismatch of CommonJS and ESM.

Still the language-service ESM output is transformed into a single UMD
bundle to allow for module resolution to be overriden. See
`bundles/BUILD`.

This is kept as is. To fully ship ESM (language-service is an exception
here), we need to:

 * Update all code to no longer reference typescript via import. Instead
   typescript needs to be passed around so that the extension can
   control the version
 * The VSCode extension/ the TS server needs to be able to load ESM. It
   looks like the server supports ESM global plugins, but the extension
   might not yet.

This is out of scope for the dev-infra effort as it requires more
insight into VSCode & the extension system & the TS language server.

PR Close #48521
2022-12-19 19:50:44 +00:00

139 lines
5.1 KiB
JSON

{
"rulesDirectory": [
"tools/tslint",
"node_modules/@angular/build-tooling/tslint-rules",
"node_modules/vrsource-tslint-rules/rules",
"node_modules/tslint-eslint-rules/dist/rules",
"node_modules/tslint-no-toplevel-property-access/rules"
],
"rules": {
// The first rule needs to be `ts-node-loader` which sets up `ts-node` within TSLint so
// that rules written in TypeScript can be loaded without needing to be transpiled.
"ts-node-loader": true,
// Custom rules written in TypeScript.
"require-internal-with-underscore": true,
"no-implicit-override-abstract": true,
"validate-import-for-esm-cjs-interop": [
true,
{
// The following CommonJS modules have type definitions that suggest the existence of
// named exports. This is not true at runtime when imported from an ES module (because
// the ESM interop only exposes statically-discoverable named exports). Instead
// default imports should be used to ensure compatibility with both ESM or CommonJS.
"noNamedExports": [
"typescript/lib/tsserverlibrary",
"typescript",
"minimist",
"magic-string",
"semver",
"yargs",
"glob",
"cluster",
"convert-source-map"
],
// The following CommonJS modules appear to have a default export available (due to the `esModuleInterop` flag),
// but at runtime with CJS (e.g. for devmode output/tests) there is no default export as these modules set
// `__esModule`. This does not match with what happens in ESM NodeJS runtime where NodeJS exposes
// `module.exports` as `export default`. Instead, named exports should be used for compat with CJS/ESM.
"noDefaultExport": [],
// List of modules which are incompatible and should never be imported at all.
"incompatibleModules": {}
}
],
"eofline": true,
"file-header": [
true,
{
"match": "Copyright Google LLC",
"allow-single-line-comments": false,
"default": "@license\nCopyright Google LLC All Rights Reserved.\n\nUse of this source code is governed by an MIT-style license that can be\nfound in the LICENSE file at https://angular.io/license"
}
],
"no-console": [true, "log"],
"no-construct": true,
"no-duplicate-imports": true,
"no-duplicate-variable": true,
"no-var-keyword": true,
"prefer-literal": [true, "object"],
"no-toplevel-property-access": [
true,
"packages/animations/src/",
"packages/animations/browser/",
"packages/common/src/",
"packages/core/src/",
"packages/elements/src/",
"packages/forms/src/",
"packages/platform-browser/src/",
"packages/router/src/"
],
"semicolon": [true],
"variable-name": [true, "ban-keywords"],
"no-inner-declarations": [true, "function"],
"no-debugger": true,
"ban": [
true,
{"name": "fdescribe", "message": "Don't keep jasmine focus methods."},
{"name": "fit", "message": "Don't keep jasmine focus methods."},
{
"name": ["*", "getMutableClone"],
"message": "Use a ts.factory.update* or ts.factory.create* method instead."
}
]
},
"jsRules": {
// The first rule needs to be `ts-node-loader` which sets up `ts-node` within TSLint so
// that rules written in TypeScript can be loaded without needing to be transpiled.
"ts-node-loader": true,
// Custom rules written in TypeScript.
"require-internal-with-underscore": true,
"eofline": true,
"file-header": [
true,
{
"match": "Copyright Google LLC",
"allow-single-line-comments": false,
"default": "@license\nCopyright Google LLC All Rights Reserved.\n\nUse of this source code is governed by an MIT-style license that can be\nfound in the LICENSE file at https://angular.io/license"
}
],
"no-console": [true, "log"],
"no-duplicate-imports": true,
"no-duplicate-variable": true,
"semicolon": [true],
"variable-name": [true, "ban-keywords"],
"no-inner-declarations": [true, "function"],
"ban": [
true,
{"name": "fdescribe", "message": "Don't keep jasmine focus methods."},
{"name": "fit", "message": "Don't keep jasmine focus methods."}
]
},
"linterOptions": {
"exclude": [
"**/node_modules/**/*",
// Ignore AIO and integration tests.
"./aio/**/*",
"./integration/**/*",
// Ignore output directories
"./built/**/*",
"./dist/**/*",
"./bazel-out/**/*",
// Ignore special files
"**/*.externs.js",
// Ignore test files
"./packages/compiler-cli/test/compliance/test_cases/**/*",
"./packages/localize/**/test_files/**/*",
"./tools/public_api_guard/**/*.d.ts",
"./modules/benchmarks_external/**/*",
// Ignore zone.js directory
// TODO(JiaLiPassion): add zone.js back later
"./packages/zone.js/**/*",
"./devtools/bazel-out/**/*",
"./devtools/projects/ng-devtools/src/lib/vendor/**/*",
// Ignore vendored code
"./third_party/**/*"
]
}
}