mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
58be2ff884
To provide some context: The implicit receiver is part of the
parsed Angular template AST. Any property reads in bindings,
interpolations etc. read from a given object (usually the component
instance). In that case there is an _implicit_ receiver which can also
be specified explicitly by just using `this`.
e.g.
```html
<ng-template>{{this.myProperty}}</ng-template>
```
This works as expected in Ivy and View Engine, but breaks in case the
implicit receiver is not used for property reads. For example:
```html
<my-dir [myFn]="greetFn.bind(this)"></my-dir>
```
In that case the `this` will not be properly translated into the generated
template function code because the Ivy compiler currently always treats
the `ctx` variable as the implicit receiver. This is **not correct** and breaks
compatibility with View Engine. Rather we need to ensure that we retrieve
the root context for the standalone implicit receiver similar to how it works
for property reads (as seen in the example above with `this.myProperty`)
Note that this requires some small changes to the `expression_converter`
because we only want to generate the `eenextContent()` instruction if the
implicit receiver is _actually_ used/needed. View Engine determines if that is the case by recursively walking through the converted output AST and
checking for usages of the `o.variable('_co')` variable ([see here][ve_check]). This would work too for Ivy, but involves most likely more code duplication
since templates are isolated in different functions and it another pass
through the output AST for every template expression.
[ve_check]:
|
||
|---|---|---|
| .. | ||
| attributes_spec.ts | ||
| BUILD.bazel | ||
| change_detection_spec.ts | ||
| common_integration_spec.ts | ||
| component_spec.ts | ||
| content_spec.ts | ||
| di_spec.ts | ||
| directive_spec.ts | ||
| discover_utils_spec.ts | ||
| embedded_views_spec.ts | ||
| exports_spec.ts | ||
| host_binding_spec.ts | ||
| i18n_spec.ts | ||
| inherit_definition_feature_spec.ts | ||
| integration_spec.ts | ||
| lifecycle_spec.ts | ||
| listener_spec.ts | ||
| outputs_spec.ts | ||
| pipe_spec.ts | ||
| property_binding_spec.ts | ||
| property_interpolation_spec.ts | ||
| providers_spec.ts | ||
| pure_function_spec.ts | ||
| query_spec.ts | ||
| renderer_factory_spec.ts | ||
| router_integration_spec.ts | ||
| styling_next_spec.ts | ||
| styling_spec.ts | ||
| template_ref_spec.ts | ||
| text_spec.ts | ||
| view_container_ref_spec.ts | ||
| view_insertion_spec.ts | ||
| view_ref_spec.ts | ||