mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
2b4d5c7548
Currently undecorated classes are intentionally not processed with ngcc. This is causing unexpected behavior because decorator handlers such as `base_def.ts` are specifically interested in class definitions without top-level decorators, so that the base definition can be generated if there are Angular-specific class members. In order to ensure that undecorated base-classes work as expected with Ivy, we need to run the decorator handlers for all top-level class declarations (not only for those with decorators). This is similar to when `ngtsc` runs decorator handlers when analyzing source-files. Resolves FW-1355. Fixes https://github.com/angular/components/issues/16178 PR Close #30821
88 lines
4 KiB
Bash
Executable file
88 lines
4 KiB
Bash
Executable file
#!/bin/bash
|
||
|
||
set -e -x
|
||
|
||
PATH=$PATH:$(npm bin)
|
||
|
||
ivy-ngcc --help
|
||
|
||
# node --inspect-brk $(npm bin)/ivy-ngcc -f esm2015
|
||
# Run ngcc and check it logged compilation output as expected
|
||
ivy-ngcc | grep 'Compiling'
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
|
||
# Did it add the appropriate build markers?
|
||
|
||
# - esm2015
|
||
cat node_modules/@angular/common/package.json | awk 'ORS=" "' | grep '"__processed_by_ivy_ngcc__":[^}]*"esm2015": "'
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
|
||
# - fesm2015
|
||
cat node_modules/@angular/common/package.json | awk 'ORS=" "' | grep '"__processed_by_ivy_ngcc__":[^}]*"fesm2015": "'
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
cat node_modules/@angular/common/package.json | awk 'ORS=" "' | grep '"__processed_by_ivy_ngcc__":[^}]*"es2015": "'
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
|
||
# - esm5
|
||
cat node_modules/@angular/common/package.json | awk 'ORS=" "' | grep '"__processed_by_ivy_ngcc__":[^}]*"esm5": "'
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
|
||
# - fesm5
|
||
cat node_modules/@angular/common/package.json | awk 'ORS=" "' | grep '"__processed_by_ivy_ngcc__":[^}]*"module": "'
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
cat node_modules/@angular/common/package.json | awk 'ORS=" "' | grep '"__processed_by_ivy_ngcc__":[^}]*"fesm5": "'
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
|
||
# Did it replace the PRE_R3 markers correctly?
|
||
grep "= SWITCH_COMPILE_COMPONENT__POST_R3__" node_modules/@angular/core/fesm2015/core.js
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
grep "= SWITCH_COMPILE_COMPONENT__POST_R3__" node_modules/@angular/core/fesm5/core.js
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
|
||
# Did it compile @angular/core/ApplicationModule correctly?
|
||
grep "ApplicationModule.ngModuleDef = ɵɵdefineNgModule" node_modules/@angular/core/fesm2015/core.js
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
grep "ApplicationModule.ngModuleDef = ɵɵdefineNgModule" node_modules/@angular/core/fesm5/core.js
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
grep "ApplicationModule.ngModuleDef = ɵngcc0.ɵɵdefineNgModule" node_modules/@angular/core/esm2015/src/application_module.js
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
grep "ApplicationModule.ngModuleDef = ɵngcc0.ɵɵdefineNgModule" node_modules/@angular/core/esm5/src/application_module.js
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
|
||
# Did it transform @angular/core typing files correctly?
|
||
grep "import [*] as ɵngcc0 from './src/r3_symbols';" node_modules/@angular/core/core.d.ts
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
grep "static ngInjectorDef: ɵngcc0.ɵɵInjectorDef<ApplicationModule>;" node_modules/@angular/core/core.d.ts
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
|
||
# Did it generate a base factory call for synthesized constructors correctly?
|
||
grep "const ɵMatTable_BaseFactory = ɵngcc0.ɵɵgetInheritedFactory(MatTable);" node_modules/@angular/material/esm2015/table.js
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
grep "const ɵMatTable_BaseFactory = ɵngcc0.ɵɵgetInheritedFactory(MatTable);" node_modules/@angular/material/esm5/table.es5.js
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
|
||
# Did it generate a base definition for undecorated classes with inputs and view queries?
|
||
grep "_MatMenuBase.ngBaseDef = ɵngcc0.ɵɵdefineBase({ inputs: {" node_modules/@angular/material/esm2015/menu.js
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
grep "_MatMenuBase.ngBaseDef = ɵngcc0.ɵɵdefineBase({ inputs: {" node_modules/@angular/material/esm5/menu.es5.js
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
|
||
# Can it be safely run again (as a noop)?
|
||
# And check that it logged skipping compilation as expected
|
||
ivy-ngcc -l debug | grep 'Skipping'
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
|
||
# Check that running it with logging level error outputs nothing
|
||
ivy-ngcc -l error | grep '.' && exit 1
|
||
|
||
# Does running it with --formats fail?
|
||
ivy-ngcc --formats fesm2015 && exit 1
|
||
|
||
# Now try compiling the app using the ngcc compiled libraries
|
||
ngc -p tsconfig-app.json
|
||
|
||
# Did it compile the main.ts correctly (including the ngIf and MatButton directives)?
|
||
grep "directives: \[.*\.NgIf.*\]" dist/src/main.js
|
||
if [[ $? != 0 ]]; then exit 1; fi
|
||
grep "directives: \[.*\.MatButton.*\]" dist/src/main.js
|
||
if [[ $? != 0 ]]; then exit 1; fi
|