mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
880a57d4b3
The comment placeholder restoration in `shimCssText` appended an unconditional
`+ '\n'` to each non-hash comment replacement. Because `_commentRe` does not
consume the newline that follows a comment in the source, that newline already
remains in `cssText`. The extra `'\n'` was therefore inserted on top of the
existing one, shifting every line after each comment down by one. In files with
many comments (e.g. large SCSS preambles) this shifts all subsequent CSS rules
far enough that the CSS sourcemap — generated before `shimCssText` runs —
points to completely wrong source locations in browser DevTools.
The fix is to drop the `+ '\n'`; internal newlines within a multi-line comment
are still preserved via `_newLinesRe`, and the trailing newline that follows the
comment in `cssText` is already present without any extra injection.
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| expression_parser | ||
| i18n | ||
| ml_parser | ||
| output | ||
| render3 | ||
| schema | ||
| template/pipeline | ||
| template_parser | ||
| chars.ts | ||
| combined_visitor.ts | ||
| compiler.ts | ||
| compiler_facade_interface.ts | ||
| config.ts | ||
| constant_pool.ts | ||
| core.ts | ||
| directive_matching.ts | ||
| injectable_compiler_2.ts | ||
| jit_compiler_facade.ts | ||
| parse_util.ts | ||
| resource_loader.ts | ||
| shadow_css.ts | ||
| style_url_resolver.ts | ||
| util.ts | ||
| version.ts | ||