angular/projects/ng-devtools/src
AleksanderBodurri 1b97432960 fix(devtools): update typing of differ objects to fit the new contract of TrackByFunction (rangle/angular-devtools#862)
Previously `DefaultIterableDiffer` was able to infer the type of it's generic by reading the type contract defined by the user defined trackBy function. This was because `TrackByFunction` can be specified with a generic that is used to type its second argument. If this generic is not provided, like in this case, typescript infers this type from the function contract directly. In this case this inferred type was `FlatNode`. This inference is then propagated to `DefaultIterableDiffer`, which is why we were not seeing this error previously.

A change in the framework made it so the second argument of `TrackByFunction` is typed as a generic that extends the generic passed into `TrackByFunction`. Since we had not previously passed in this generic to `TrackByFunction`, this type was inferred as an extension of `unknown`, causing a type error when passed as an argument to the `DefaultIterableDiffer` constructor.

Now the functions being used are typed directly as `TrackByFunction<FlatNode>`

For clarity, the `DefaultIterableDiffer` generic is now also typed as `FlatNode`.

See https://github.com/angular/angular/pull/41995 for the framework change.
2021-06-21 17:56:43 -07:00
..
lib fix(devtools): update typing of differ objects to fit the new contract of TrackByFunction (rangle/angular-devtools#862) 2021-06-21 17:56:43 -07:00
public-api.ts feat(devtools): display latest commit SHA in application (rangle/angular-devtools#243) 2020-04-02 16:23:03 -07:00
test.ts feat(devtools): added prettier for formatting code on pre-commit (rangle/angular-devtools#50) 2020-02-07 13:25:16 -08:00