angular/packages/language-service
Dylan Hunn e6affeff61 fix(language-service): Autocomplete block keywords in more cases (#52198)
Previously, autocompletions were not available in two main cases. We correct them.

1. Autocompletions immediately after `@` were usually not working, for example `foo @|`. We fix this by causing the lexer to not consider the `@` part of the text node.
2. Autocompletions such as `@\nfoo`, where a newline follows a bare `@`, were not working because the language service visitor considered us inside the subsequent text node. We fix this by adding a block name span for the block keyword, and special-case whether we are completing inside the name span. If we are, we don't continue to the following text node.

PR Close #52198
2023-10-23 12:01:52 -07:00
..
bundles build: switch all instances from ng_rollup_bundle to app_bundle (#44490) 2022-01-04 12:14:14 -08:00
src fix(language-service): Autocomplete block keywords in more cases (#52198) 2023-10-23 12:01:52 -07:00
test fix(language-service): Autocomplete block keywords in more cases (#52198) 2023-10-23 12:01:52 -07:00
testing feat(language-service): Implement outlining spans for control flow blocks (#52062) 2023-10-09 10:20:26 -07:00
api.ts fix(language-service): Retain correct language service when ts.Project reloads (#51912) 2023-10-04 11:27:43 -07:00
BUILD.bazel fix(language-service): ship /api entry-point (#48670) 2023-01-09 10:13:34 -08:00
build.sh fix(language-service): update packages/language-service/build.sh script to work with vscode-ng-language-service's new Bazel build (#48663) 2023-01-09 10:13:06 -08:00
index.d.ts refactor: update language-service package and tests to work with ESM (#48521) 2022-12-19 19:50:44 +00:00
index.js refactor: update language-service package and tests to work with ESM (#48521) 2022-12-19 19:50:44 +00:00
override_rename_ts_plugin.ts refactor: update language-service package and tests to work with ESM (#48521) 2022-12-19 19:50:44 +00:00
package.json build: remove support for Node.js v16 (#51755) 2023-09-13 10:49:06 -07:00
plugin-factory.ts refactor: update language-service package and tests to work with ESM (#48521) 2022-12-19 19:50:44 +00:00
README.md feat(language-service): Provide plugin to delegate rename requests to Angular (#44696) 2022-01-21 11:18:48 -08:00

Override Rename Ts Plugin

When the user wants to rename a symbol in the ts file VSCode will ask the rename providers for the answer in turn. If the first extension returns the result, the VSCode will break the loop and apply the result. If the first extension cannot rename the symbol, VSCode will ask the second extension in the list (built-in TS/JS extension, Angular LS extension, etc.). In other words, VSCode takes the result from only one rename provider and the order depends on registration timing, scoring.

Because the built-in ts extension and Angular extension have the same high score, if the built-in ts extension is the first(depends on the time the extension was registered), the result will be provided by the built-in extension. We want Angular to provide it, so this plugin will delegate rename requests and reject the request for the built-in ts server.

The Angular LS only provides the rename info when working within an Angular project. If we cannot locate Angular sources in the project files, the built-in extension should provide the rename info.

This plugin will apply to the built-in TS/JS extension and delegate rename requests to the Angular LS. It provides the rename info only when it is an Angular project. Otherwise, it will return info by the default built-in ts server rename provider.

See here for more info.