mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
9f3b549cf6
Although there are several pages, only `service-worker-getting-started.md` has an example. That example code was migrated. Worked around the few references to NgModule. Other changes as follows: **Revised "Getting Started"** The original service worker example page (`service-worker-getting-started.md`) is full of holes! I don’t know how anyone got this working just by following this page - it doesn’t tell you where to get the example (and it isn’t generated by AIO) - it doesn’t tell you that ng serve doesn’t support service worker apps - it mentions http-server in passing but not what that is or where to get it. - several commands tell you to supply the “project-name” but (a) it doesn’t tell you how to find that name and (b) you never actually have to provide a name at all. That includes on the command that gets http-server going. **Hid section on `ngsw-config` tool** Hid the discussion of the `ngsw-config` tool in `service-worker-config.md` because (a) the command invoke it didn't seem to work and (b) it referenced `<project-name>` without explaining what that is or where to find it. Left the hidden text in the page in case someone wants to do something about this. Meanwhile, you seem to be able to edit the `ngsw-config.json` and then rebuild. That should suffice. **Disabled E2E** The AIO CI will no longer attempt to run the (thin) E2E tests. These tests could lightly test the app with the dev server but couldn't test the Service Worker aspects; that would require launching the app with something other than `ng serve` and the AIO CI is not set up for that. The existing tests appeared to pass when run locally with the dev server. However, only one of them actually ran; test runner reported. "There were tests whose specified size is too big." Decided to bypass E2E testing of this project for now. PR Close #51687
7 lines
75 B
JSON
7 lines
75 B
JSON
{
|
|
"files": [
|
|
"!dist/",
|
|
"!**/*.d.ts",
|
|
"!**/src/**/*.js"
|
|
]
|
|
}
|