mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
008eaf3b7d
Close #41522 `zone.js` patches event listeners and run all event listeners together, if one event handler throws error, the listeners afterward may not be invoked. Reproduction: ``` export class AppComponent implements AfterViewInit { @ViewChild('btn') btn: ElementRef; title = 'event-error'; constructor(private ngZone: NgZone) {} ngAfterViewInit() { this.ngZone.runOutsideAngular(() => { this.btn.nativeElement.addEventListener('click', () => { throw new Error('test1'); }); this.btn.nativeElement.addEventListener('click', () => { console.log('add eventlistener click'); }); }); } } ``` Until now no Angular users report this issue becuase in the `ngZone`, all error will be caught and will not rethrow, so the event listeners afterward will still continue to execute, but if the event handlers are outside of `ngZone`, the error will break the execution. This commit catch all errors, and after all event listeners finished invocation, rethrow the errors in seperate `microTasks`, the reason I am using `microTask` here is to handle multiple errors case. PR Close #41562 |
||
|---|---|---|
| .. | ||
| api-util.ts | ||
| browser-legacy.ts | ||
| browser-util.ts | ||
| browser.ts | ||
| canvas.ts | ||
| custom-elements.ts | ||
| define-property.ts | ||
| event-target-legacy.ts | ||
| event-target.ts | ||
| message-port.ts | ||
| property-descriptor-legacy.ts | ||
| property-descriptor.ts | ||
| register-element.ts | ||
| rollup-common.ts | ||
| rollup-legacy-main.ts | ||
| rollup-legacy-test-main.ts | ||
| rollup-main.ts | ||
| rollup-test-main.ts | ||
| shadydom.ts | ||
| webapis-media-query.ts | ||
| webapis-notification.ts | ||
| webapis-resize-observer.ts | ||
| webapis-rtc-peer-connection.ts | ||
| webapis-user-media.ts | ||
| websocket.ts | ||