mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
e0a72857cc
Refs #42966. Previously if _any_ diagnostics were emitted, regardless of their category, the manifest would not be generated. This means that if a target emits only warnings and no errors, it would still fail to build because it does not generate all the required output files (specifically the `.es5.MF` file). Now the manifest file is generated as long as there are no error diagnostics in the result. This makes `ng_module()` support compiler warnings as a user would expect. Added a test which uses extended template diagnostics to trigger the invalid banana in box diagnostic. This generates a warning and uses Skylib's `build_test()` to verify that it builds successfully. Unfortunately there is no easy way to verify that the warning diagnostic is emitted at all. `expected_diagnostics` should be able to do that, but it doesn't seem to have any effect on `ng_module()` and may not be integrated. Instead, testing that a target with warnings builds correctly is the best we can easily do here without a deeper investigation. PR Close #43582 |
||
|---|---|---|
| .. | ||
| api-extractor | ||
| ng_package | ||
| ngc-wrapped | ||
| BUILD.bazel | ||
| external.bzl | ||
| modify_tsconfig.js | ||
| ng_module.bzl | ||
| ng_perf.bzl | ||