mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
2ca72faab1
Improves the partial compliance golden generation to not rely on large files being transmitted via `stdout`. Instead the files are written directly as it's done in idiomatic Bazel generation actions. In addition, we add extra stdout logging for the Bazel action, to see if the process is actually invoked in RBE workers. Right now those are occassionally stuck, but neither us, nor the RBE team can see anything running, and they're occasionally stuck for 1hr. PR Close #60427
80 lines
2.6 KiB
TypeScript
80 lines
2.6 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google LLC All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.dev/license
|
|
*/
|
|
import fs from 'node:fs';
|
|
import {AbsoluteFsPath, FileSystem} from '../../../src/ngtsc/file_system';
|
|
import {
|
|
compileTest,
|
|
getBuildOutputDirectory,
|
|
initMockTestFileSystem,
|
|
} from '../test_helpers/compile_test';
|
|
import {ComplianceTest, getComplianceTests} from '../test_helpers/get_compliance_tests';
|
|
import {PartiallyCompiledFile, renderGoldenPartial} from '../test_helpers/golden_partials';
|
|
|
|
/**
|
|
* Generate the golden partial output for the tests described in the `testConfigPath` config file.
|
|
*
|
|
* @param testConfigPath Absolute disk path of the `TEST_CASES.json` file that describes the tests.
|
|
* @param outputPath Absolute disk path for the golden output.
|
|
*/
|
|
export function generateGoldenPartial(
|
|
absTestConfigPath: AbsoluteFsPath,
|
|
outputPath: AbsoluteFsPath,
|
|
): void {
|
|
const files: PartiallyCompiledFile[] = [];
|
|
const tests = getComplianceTests(absTestConfigPath);
|
|
for (const test of tests) {
|
|
const fs = initMockTestFileSystem(test.realTestPath);
|
|
for (const file of compilePartials(fs, test)) {
|
|
files.push(file);
|
|
}
|
|
}
|
|
writeGoldenPartial(files, outputPath);
|
|
}
|
|
|
|
/**
|
|
* Partially compile the source files specified by the given `test`.
|
|
*
|
|
* @param fs The mock file-system to use when compiling partials.
|
|
* @param test The information about the test being compiled.
|
|
*/
|
|
function* compilePartials(fs: FileSystem, test: ComplianceTest): Generator<PartiallyCompiledFile> {
|
|
const builtDirectory = getBuildOutputDirectory(fs);
|
|
const result = compileTest(fs, test.inputFiles, test.compilerOptions, {
|
|
compilationMode: 'partial',
|
|
...test.angularCompilerOptions,
|
|
});
|
|
|
|
if (result.errors.length > 0) {
|
|
throw new Error(
|
|
`Unexpected compilation errors: ${result.errors.map((e) => ` - ${e}`).join('\n')}`,
|
|
);
|
|
}
|
|
|
|
for (const generatedPath of result.emittedFiles) {
|
|
yield {
|
|
path: fs.relative(builtDirectory, generatedPath),
|
|
content: fs.readFile(generatedPath),
|
|
};
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Write the partially compiled files to the appropriate output destination.
|
|
*
|
|
* @param files The partially compiled files.
|
|
* @param outputPath absolute disk path for the golden to write to.
|
|
*/
|
|
function writeGoldenPartial(files: PartiallyCompiledFile[], outputPath: AbsoluteFsPath): void {
|
|
const goldenOutput = renderGoldenPartial(files);
|
|
fs.writeFileSync(
|
|
outputPath,
|
|
// Note: Keeping trailing \n as otherwise many goldens need to be re-approved.
|
|
goldenOutput + '\n',
|
|
'utf8',
|
|
);
|
|
}
|