mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
c8cd5d5f2c
The `ng_rollup_bundle` rule has been replaced with a new rule called `app_bundle`. This rule replicates the Angular v13 optimization pipeline in the CLI, so that we can get better benchmarking results. Also the rule is much simpler to maintain as it relies on ESbuild. The old `ng_rollup_bundle` rule did rely on e.g. build-optimizer that no longer has an effect on v13 Angular packages, so technically size tests/symbol tests were no longer as correct as they were before. This commit fixes that. A couple of different changes and their explanation: * Language-service will no longer use the benchmark rule for creating its NPM bundles! It will use plain `rollup_bundle`. ESBuild would have been nice but the language-service relies on AMD that ESBuild cannot generate (yet?) * Service-worker ngsw-worker.js file was generated using the benchmark bundle rule. This is wrong. We will use a simple ESbuild rule in the future. The output is more predictable that way, and we can have a clear use of the benchmark bundle rule.. * A couple of benchmarks in `modules/` had to be updated to use e.g. `initTableUtils` calls. This is done because with the new rule, all files except for the entry-point are considered side-effect free. The utilities for benchmarks relied on side-effects in some transitively-loaded file (bad practice anyway IMO). We are now initializing the utilities using a proper init function that is exported... PR Close #44490 |
||
|---|---|---|
| .. | ||
| change_detection | ||
| class_bindings | ||
| expanding_rows | ||
| js-web-frameworks | ||
| largeform | ||
| largetable | ||
| old | ||
| styling | ||
| tree | ||
| views | ||
| bootstrap_ng2.ts | ||
| bootstrap_plain.ts | ||
| BUILD.bazel | ||
| README.md | ||
| util.ts | ||
Benchmark Directory Layout
Bazel
Under bazel the rules for laying out test files are slightly different. Use largetable/render3 as an example.
Put the perf file in current subdirectory (ie largetable) such that the same perf file can be used for each of the sub-subdirectories. (ie largetable/* should all be testable with the same perf file largetable/largetable_perf.spec.ts). Under bazel, typescript protractor spec files must end with .spec.ts or .test.ts.