mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
078b0be4dc
Although this code has been part of Angular 9.x I only noticed this error when upgrading to Angular 9.1.x because historically the source locale data was not injected when localizing, but as of angular/angular-cli#16394 (9.1.0) it is now included. This tipped me off that my other bundles were not being built properly, and this change allows me to build a valid ES5 bundle (I have also added a verification step to my build pipeline to alert me if this error appears again in any of my bundles). I found the `locales/global/*.js` file paths being referenced by the `I18nOptions` in @angular-devkit/build-angular/src/utils/i18n-options.ts, and following that it looks like it is actually loaded and used in @angular-devkit/build-angular/src/utils/process-bundle.ts. I saw the function `terserMangle` does appear that it is likely aware of the build being ES5, but I'm not sure why this is not producing a valid ES5 bundle. This change updates `tools/gulp-tasks/cldr/extract.js` to produce ES5 compliant `locales/global/*.js` and that fixes my issue. However, I am not sure if @angular-devkit/build-angular should be modified to produce a valid ES5 bundle instead or if the files could be TypeScript rather than JavaScript files. A test that a valid ES5 bundle is produced would be helpful, and I hope this is reproducible and not some issue with my config. PR Close #36342 |
||
|---|---|---|
| .. | ||
| brotli-cli | ||
| browsers | ||
| build | ||
| circular_dependency_test | ||
| components | ||
| contributing-stats | ||
| gulp-tasks | ||
| ng_rollup_bundle | ||
| ngcontainer | ||
| npm | ||
| npm_integration_test | ||
| rxjs | ||
| saucelabs | ||
| size-tracking | ||
| source-map-test | ||
| symbol-extractor | ||
| testing | ||
| ts-api-guardian | ||
| tslint | ||
| utils | ||
| yarn | ||
| bazel_stamp_vars.js | ||
| BUILD.bazel | ||
| check-environment.js | ||
| defaults.bzl | ||
| inline-package-json-deps.js | ||
| jasmine-seed-generator.js | ||
| jsconfig.json | ||
| ng_benchmark.bzl | ||
| postinstall-patches.js | ||
| rebase-pr.js | ||
| tsconfig-test.json | ||
| tsconfig.json | ||
| types.d.ts | ||
| utils.inc | ||