mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
810b0a7e5c
As part of the Bazel toolchain migration we noticed that implicit types generated by the TypeScript compiler sometimes end up referencing types from other packages (i.e. cross-package imports). These imports currently work just because the Bazel `ts_library` and `ng_module` rules automatically inserted a `<amd-module name="@angular/x" />` into `.d.ts` of packages. This helped TS figure out how to import a given file. Notably this is custom logic that is not occuring in vanilla TS or Angular compilations—so we will drop this magic as part of the toolchain cleanup! To improve code quality and keep the existing behavior working, we are doing the following: - adding a lint rule that reduces the risk of such imports breaking. The failure scenario without the rule is that API goldens show unexpected diffs, and types might be duplicated in a different package! - keeping the `<amd-module` headers, but we manually insert them into the package entry-points. This should ensure we don't regress anywhere; while we also improved general safety around this above. Long-term, isolated declarations or a lint rule from eslint-typescript can make this even more robust. PR Close #61312
35 lines
1.6 KiB
TypeScript
35 lines
1.6 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google LLC All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.dev/license
|
|
*/
|
|
|
|
import {getClosureSafeProperty} from '../util/property';
|
|
|
|
export const NG_COMP_DEF: string = getClosureSafeProperty({ɵcmp: getClosureSafeProperty});
|
|
export const NG_DIR_DEF: string = getClosureSafeProperty({ɵdir: getClosureSafeProperty});
|
|
export const NG_PIPE_DEF: string = getClosureSafeProperty({ɵpipe: getClosureSafeProperty});
|
|
export const NG_MOD_DEF: string = getClosureSafeProperty({ɵmod: getClosureSafeProperty});
|
|
export const NG_FACTORY_DEF: string = getClosureSafeProperty({ɵfac: getClosureSafeProperty});
|
|
|
|
/**
|
|
* If a directive is diPublic, bloomAdd sets a property on the type with this constant as
|
|
* the key and the directive's unique ID as the value. This allows us to map directives to their
|
|
* bloom filter bit for DI.
|
|
*/
|
|
// TODO(misko): This is wrong. The NG_ELEMENT_ID should never be minified.
|
|
export const NG_ELEMENT_ID: string = getClosureSafeProperty({
|
|
__NG_ELEMENT_ID__: getClosureSafeProperty,
|
|
});
|
|
|
|
/**
|
|
* The `NG_ENV_ID` field on a DI token indicates special processing in the `EnvironmentInjector`:
|
|
* getting such tokens from the `EnvironmentInjector` will bypass the standard DI resolution
|
|
* strategy and instead will return implementation produced by the `NG_ENV_ID` factory function.
|
|
*
|
|
* This particular retrieval of DI tokens is mostly done to eliminate circular dependencies and
|
|
* improve tree-shaking.
|
|
*/
|
|
export const NG_ENV_ID: string = getClosureSafeProperty({__NG_ENV_ID__: getClosureSafeProperty});
|