mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
fdbd3cae8a
The `NgControlStatusGroup` directive is shared between template-driven and reactive form modules. In cases when only reactive forms module is present, the `NgControlStatusGroup` directive is still activated on all `<form>` elements, but if there is no other reactive directive applied (such as `formGroup`), corresponding `ControlContainer` token is missing, thus causing exceptions (since `NgControlStatusGroup` directive relies on it to determine the status). This commit updates the logic to handle the case when no `ControlContainer` is present (effectively making directive logic a noop in this case). Alternative approach (more risky) worth considering in the future is to split the `NgControlStatusGroup` into 2 directives with different set of selectors and include them into template-driven and reactive modules separately. The downside is that these directives might be activated simultaneously on the same element (e.g. `<form>`), effectively doing the work twice. Resolves #38391. PR Close #40344 |
||
|---|---|---|
| .. | ||
| reactive_directives | ||
| abstract_control_directive.ts | ||
| abstract_form_group_directive.ts | ||
| checkbox_value_accessor.ts | ||
| control_container.ts | ||
| control_value_accessor.ts | ||
| default_value_accessor.ts | ||
| error_examples.ts | ||
| form_interface.ts | ||
| ng_control.ts | ||
| ng_control_status.ts | ||
| ng_form.ts | ||
| ng_model.ts | ||
| ng_model_group.ts | ||
| ng_no_validate_directive.ts | ||
| number_value_accessor.ts | ||
| radio_control_value_accessor.ts | ||
| range_value_accessor.ts | ||
| reactive_errors.ts | ||
| select_control_value_accessor.ts | ||
| select_multiple_control_value_accessor.ts | ||
| shared.ts | ||
| template_driven_errors.ts | ||
| validators.ts | ||