mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
If we try to resolve the benchmark compare ref (which may be just
`main`), we are just looking inside the PR branch- but that may
not include the `main` SHA. i.e. it's possible to run a comparison
where the PR is slightly behind of the `main` branch, or a comparison
commit from a different branch is used.
We fix this/ and simplify the logic by resolving the SHAs directly in
the TypeScript code, instead of relying on the rather brittle Bash.
Note that current solution still works, but we sometimes may not be able
to resolve to an actual SHA- causing issues as in
|
||
|---|---|---|
| .. | ||
| benchmarks | ||
| build | ||
| ci | ||
| test | ||
| compare-main-to-patch.js | ||
| tsconfig.json | ||