mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
Refactor attribute and property binding ingestion and add an attribute extraction phase Co-authored-by: Alex Rickabaugh <alxhub@users.noreply.github.com> Co-authored-by: Dylan Hunn <dylhunn@users.noreply.github.com> Only add the value to the ElementAttributes map for style and attribute kinds Other kinds should not have their value represented in the consts array Add missing attribute ingesiton for templates Unify how template and element bindings are ingested This resolves the issue of missing listener attributes on templates. In order to avoid emitting extraneous instructions, listener ops on templates are stripped in the attribute extraction phase instead. Handle different binding types separately in ingest Cleanup code and comments Disable test that fails on new explicit error. Previously the test was passing because ingestPropertyBinding treated attribute bindings as normal bindings which happened to be ok for the particular test. Now there's an explicit error that attrbiute bindings aren't yet handled which causes the test to fail Address feeback PR Close #50664 |
||
|---|---|---|
| .. | ||
| integrationtest | ||
| linker | ||
| ngcc | ||
| private | ||
| src | ||
| test | ||
| BUILD.bazel | ||
| esbuild.config.js | ||
| index.ts | ||
| package.json | ||
| tsconfig-build.json | ||
| tsconfig.json | ||