mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
1177b4e2f8
For quite some time now, since we started to use Bazel for integration tests, we relied on some size tracking logic that did not actually fully work under Bazel. It was thought that all the necessary CI push/PR information is available to the Bazel test, but that was not the case. This was now fixed with the recent Rules NodeJS v5 update where I made sure the `env.sh` variables are actually available before we write them to the temporary file for the Bazel-access. This now will unveil an issue because payload size goldens would start being based on their branch name. e.g. the golden key in `13.3.x` should not be `master` but `13.3.x`. This makes more sense than `master` as key, but makes things more cumbersome and ideally we would not store the branch name at all (this is a larger change though -- not worth now since we might refactor this anyway). For now we will update the size tracking logic to always use `master` as golden key (like it worked in the past year(s)) With the environment fix we now (again) start uploading payload size results to Firebase. This did not work by accident either. The uploading logic is reliant on the CircleCI commit range which is not working/reliable in upstream branches. This commit removes this reliance on `COMMIT_RANGE` since it's not strictly necessary and currently breaking renovate PRs. We can re-enable this when we have a solution with CircleCI, or a workaround/resolution logic provided in e.g. `ng-dev ci determine-commit-range`. PR Close #45444
82 lines
3.3 KiB
JavaScript
82 lines
3.3 KiB
JavaScript
/**
|
|
* @license
|
|
* Copyright Google LLC All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
// Imports
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
// Get branch and project name from command line arguments.
|
|
const [, , limitFile, project, commit] = process.argv;
|
|
|
|
// Load sizes.
|
|
const currentSizes = JSON.parse(fs.readFileSync('/tmp/current.log', 'utf8'));
|
|
const allLimitSizes = JSON.parse(fs.readFileSync(limitFile, 'utf8'));
|
|
|
|
// TODO: Change the `master` golden key to something more obvious, or remove it. The branch
|
|
// name is unreasonable since the limits are always taken from the currently checked-out revision.
|
|
const limitSizes = allLimitSizes[project]['master'];
|
|
|
|
// Check current sizes against limits.
|
|
let failed = false;
|
|
const successMessages = [];
|
|
const failureMessages = [];
|
|
for (const compressionType in limitSizes) {
|
|
if (typeof limitSizes[compressionType] === 'object') {
|
|
const limitPerFile = limitSizes[compressionType];
|
|
|
|
for (const filename in limitPerFile) {
|
|
const expectedSize = limitPerFile[filename];
|
|
const actualSize = currentSizes[`${compressionType}/${filename}`];
|
|
|
|
if (actualSize === undefined) {
|
|
failed = true;
|
|
// An expected compression type/file combination is missing. Maybe the file was renamed or
|
|
// removed. Report it as an error, so the user updates the corresponding limit file.
|
|
console.error(
|
|
`ERROR: Commit ${commit} ${compressionType} ${filename} measurement is missing. ` +
|
|
'Maybe the file was renamed or removed.');
|
|
} else {
|
|
const absoluteSizeDiff = Math.abs(actualSize - expectedSize);
|
|
// If size diff is larger than 1% or 500 bytes...
|
|
if (absoluteSizeDiff > 500 || absoluteSizeDiff > expectedSize / 100) {
|
|
failed = true;
|
|
// We must also catch when the size is significantly lower than the payload limit, so
|
|
// we are forced to update the expected payload number when the payload size reduces.
|
|
// Otherwise, we won't be able to catch future regressions that happen to be below
|
|
// the artificially inflated limit.
|
|
const operator = actualSize > expectedSize ? 'exceeded' : 'fell below';
|
|
|
|
failureMessages.push(
|
|
`FAIL: Commit ${commit} ${compressionType} ${filename} ${
|
|
operator} expected size by 500 bytes or >1% ` +
|
|
`(expected: ${expectedSize}, actual: ${actualSize}).`);
|
|
} else {
|
|
successMessages.push(
|
|
`SUCCESS: Commit ${commit} ${compressionType} ${
|
|
filename} did NOT cross size threshold of 500 bytes or >1% ` +
|
|
`(expected: ${expectedSize}, actual: ${actualSize}).`);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// Group failure messages separately from success messages so they are easier to find.
|
|
successMessages.concat(failureMessages).forEach(message => console.error(message));
|
|
|
|
if (failed) {
|
|
const projectRoot = path.resolve(__dirname, '../..');
|
|
const limitFileRelPath = path.relative(projectRoot, limitFile);
|
|
console.info(
|
|
`If this is a desired change, please update the size limits in file '${limitFileRelPath}'.`);
|
|
process.exit(1);
|
|
} else {
|
|
console.info(`Payload size check passed. All diffs are less than 1% or 500 bytes.`);
|
|
}
|