mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
c8cd5d5f2c
The `ng_rollup_bundle` rule has been replaced with a new rule called `app_bundle`. This rule replicates the Angular v13 optimization pipeline in the CLI, so that we can get better benchmarking results. Also the rule is much simpler to maintain as it relies on ESbuild. The old `ng_rollup_bundle` rule did rely on e.g. build-optimizer that no longer has an effect on v13 Angular packages, so technically size tests/symbol tests were no longer as correct as they were before. This commit fixes that. A couple of different changes and their explanation: * Language-service will no longer use the benchmark rule for creating its NPM bundles! It will use plain `rollup_bundle`. ESBuild would have been nice but the language-service relies on AMD that ESBuild cannot generate (yet?) * Service-worker ngsw-worker.js file was generated using the benchmark bundle rule. This is wrong. We will use a simple ESbuild rule in the future. The output is more predictable that way, and we can have a clear use of the benchmark bundle rule.. * A couple of benchmarks in `modules/` had to be updated to use e.g. `initTableUtils` calls. This is done because with the new rule, all files except for the entry-point are considered side-effect free. The utilities for benchmarks relied on side-effects in some transitively-loaded file (bad practice anyway IMO). We are now initializing the utilities using a proper init function that is exported... PR Close #44490
32 lines
1.1 KiB
Python
32 lines
1.1 KiB
Python
# Copyright Google LLC All Rights Reserved.
|
|
#
|
|
# Use of this source code is governed by an MIT-style license that can be
|
|
# found in the LICENSE file at https://angular.io/license
|
|
"""Bazel macro for running Angular benchmarks"""
|
|
|
|
load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
|
|
|
|
def ng_benchmark(name, bundle):
|
|
"""
|
|
|
|
This macro creates two targets, one that is runnable and prints results and one that can be used for profiling via chrome://inspect.
|
|
|
|
Args:
|
|
name: name of the runnable rule to create
|
|
bundle: label of the bundle rule to run
|
|
"""
|
|
|
|
nodejs_binary(
|
|
name = name,
|
|
data = [bundle],
|
|
entry_point = bundle + ".debug.min.js",
|
|
tags = ["local", "manual"], # run benchmarks locally and never on CI
|
|
)
|
|
|
|
nodejs_binary(
|
|
name = name + "_profile",
|
|
data = [bundle],
|
|
entry_point = bundle + ".debug.min.js",
|
|
args = ["--node_options=--no-turbo-inlining --node_options=--inspect-brk"],
|
|
tags = ["local", "manual"], # run benchmarks locally and never on CI
|
|
)
|