AleksanderBodurri
e332d5ded1
refactor(devtools): remove unnecessary logic from property editor
2020-03-31 08:38:38 -07:00
AleksanderBodurri
1320c8d36f
refactor(devtools): rename tree graph to tree map
2020-03-31 07:39:15 -07:00
AleksanderBodurri
f4e404c8ce
refactor(devtools): remove scrollIntoView ponyfill
2020-03-30 13:23:44 -07:00
AleksanderBodurri
e60d9fb23a
refactor(devtools): lift breadcrumbs up a level on the component tree to avoid using fixed positioning css
2020-03-30 13:23:44 -07:00
AleksanderBodurri
e1691b2ab5
fix(devtools): prevent default behaviour before calculating new scroll position to fix bug when traversing directive forest with arrow keys ( rangle/angular-devtools#213 )
2020-03-30 12:35:47 -07:00
AleksanderBodurri
be7a0c25cb
feat(devtools): set showNode option to show most nodes in the treegraph ( rangle/angular-devtools#219 )
2020-03-30 12:35:21 -07:00
mgechev
20398cfa52
perf(devtools): faster bar chart formatting
...
The array allocation in `addSpaces` was talking a lot of time. We were also recomputing same result very frequently.
2020-03-30 12:33:03 -07:00
mgechev
1cce9117a0
refactor(devtools): use single color in the bar chart
...
Lots of folks are confused by the multiple colors which don't have meaning at the moment.
2020-03-30 15:22:10 -04:00
AleksanderBodurri
957034bf93
feat(devtools): migrate devtools and demo app to scss for styling
2020-03-29 13:49:19 -07:00
AleksanderBodurri
5b0ca27360
refactor(devtools): move all profiler files to be under devtool-tabs where the initial profiler component is rendered
2020-03-28 12:56:05 -07:00
Sumit Arora
53da6bb0a8
feat(devtools): updating record formatter to get directive values
2020-03-27 21:23:05 -07:00
Sumit Arora
b4dc6f7bea
feat(devtools): updating bargraph formatter
2020-03-27 21:23:05 -07:00
Sumit Arora
2bfb96d5bb
feat(devtools): setting bar graph as default option
2020-03-27 21:23:05 -07:00
Sumit Arora
b3a948eca3
feat(devtools): renaming timeline graph options
2020-03-27 21:23:05 -07:00
Sumit Arora
637c6de204
feat(devtools): adding bargraph visualization to timeline
2020-03-27 21:23:05 -07:00
Sumit Arora
2b48785931
feat(devtools): adding bargraph visualizer
2020-03-27 21:23:05 -07:00
Sumit Arora
556997abab
feat(devtools): adding bargraph formatter
2020-03-27 21:23:05 -07:00
AleksanderBodurri
97f88712e6
fix(devtools): drag and drop when selecting input; fix: console warning on update state error ( rangle/angular-devtools#205 )
...
* fix: console warn correct variable on update state failure
* fix: prevent drag from occuring on property edit inputs
2020-03-27 15:59:03 -07:00
AleksanderBodurri
fcfc9ebdc1
fix(devtools): webtree sizing ( rangle/angular-devtools#203 )
2020-03-27 15:57:10 -07:00
AleksanderBodurri
158ffd5875
refactor(devtools): use parents state in directive forest to optimize the expandParents method called when searching the directive forest ( rangle/angular-devtools#197 )
2020-03-26 19:12:34 -07:00
mgechev
ae6acce53e
fix(devtools): highlighting of newly added nodes
...
This PR also simplifies the imperative ordering of async methods. It moves the logic into a generic abstraction `PriorityAwareMessageBus`.
2020-03-23 21:24:27 -07:00
AleksanderBodurri
8b9181724b
feat(devtools): only show console reference for the currently selected element to reduce noise
2020-03-23 17:41:52 -07:00
AleksanderBodurri
60a4e56a95
feat(devtools): apply style to console reference keys displayed on nodes
2020-03-23 17:41:52 -07:00
AleksanderBodurri
a25cd0ed15
feat(devtools): show the console reference key on each selected element
2020-03-23 17:41:52 -07:00
AleksanderBodurri
0b5e892d84
build(devtools): enable no-unused-variable lint check with warning severity
2020-03-23 17:41:10 -07:00
AleksanderBodurri
a6148608c3
feat(devtools): open expansion panels by default; apply styling to expansion header
2020-03-22 19:59:30 -07:00
AleksanderBodurri
11c1cb01f7
refactor(devtools): replace label arrays with sets because Set.has is much faster than Array.includes
2020-03-22 19:59:30 -07:00
AleksanderBodurri
789c872ada
refactor(devtools): type propPointer and drag event properly
2020-03-22 19:59:30 -07:00
AleksanderBodurri
95dcad328f
refactor(devtools): clean up directive property resolver methods
2020-03-22 19:59:30 -07:00
AleksanderBodurri
820ec85ea4
fix(devtools): pass property updates to the correct data sources
2020-03-22 19:59:30 -07:00
AleksanderBodurri
3a6b5b0bd9
refactor(devtools): remove old unused methods from property tab body, client event subscribers, and directive property resolver
2020-03-22 19:59:30 -07:00
AleksanderBodurri
d0a1773175
feat(devtools): implement material expansion panel with drag functionality for each property tree
2020-03-22 19:59:30 -07:00
AleksanderBodurri
6d0c4093c2
feat(devtools): pass each datasource through to it's own material tree component
2020-03-22 19:59:30 -07:00
AleksanderBodurri
2d34a209a6
feat(devtools): create seperate property data sources for inputs/outputs/state
2020-03-22 19:59:30 -07:00
AleksanderBodurri
8ea84d5776
feat(devtools): implement input/output/state preview functionality with the reworked property explorer
2020-03-22 19:59:30 -07:00
AleksanderBodurri
39b65dd05a
refactor(devtools): organize property explorer components
2020-03-22 19:59:30 -07:00
Sumit Arora
3d19ebf3a1
fix(devtools): added more padding to treegraph
2020-03-22 12:14:05 -04:00
mgechev
b127cdc211
fix(devtools): prevent race condition between getting nested props and refresh
2020-03-21 19:09:12 -07:00
mgechev
b010784b21
fix(devtools): do not expand HTML Comments and preserve state for selected nodes
2020-03-21 19:09:12 -07:00
mgechev
5f5307e610
fix(devtools): flicker properties when update selected node
...
Fix rangle/angular-devtools#171
The PR includes few changes:
1. Fixes a race condition between two competing async calls
2. Simplifies the message bus, now we have one method for getting the component tree instead of one for getting the component tree and another for getting properties. Similarly to GraphQL we send a query for exactly what we need.
3. Fixes the way we update properties in the UI once we receive new items
2020-03-21 19:09:12 -07:00
Sumit Arora
ee7d8e58c6
feat(devtools): making small frames clickable
2020-03-21 18:53:56 -07:00
Minko Gechev
6a6059d2b1
build(devtools): enable strictNullChecks ( rangle/angular-devtools#167 )
2020-03-20 11:54:37 -07:00
Sumit Arora
75cb030a84
feat(devtools): adding bar chart for timeline
2020-03-19 19:15:07 -07:00
mgechev
14e51e8875
test(devtools): verify that the app can select elements with the same name
2020-03-19 21:17:26 -04:00
mgechev
f4db6d7a44
test(devtools): add specs for the element property resolver
2020-03-19 21:17:26 -04:00
mgechev
b3b8c93656
test(devtools): fix typing errors in the specs
2020-03-19 21:17:26 -04:00
mgechev
f93b53bb89
fix(devtools): proper alignment of non-expandable props
2020-03-19 21:17:26 -04:00
mgechev
dce46e5411
refactor(devtools): move abstractions to separate files
2020-03-19 21:17:26 -04:00
mgechev
370a600481
refactor(devtools): use shared store between parent and child components
2020-03-19 21:17:26 -04:00
mgechev
2f115a2448
refactor(devtools): use DI for the messageBus instead of passing it as props
2020-03-19 21:17:26 -04:00
mgechev
25a6ecc438
refactor(devtools): reuse prop instances in the data source
2020-03-19 21:17:26 -04:00
mgechev
2a1f6e9464
fix(devtools): do not refresh the ui unless there are updates
2020-03-19 21:17:26 -04:00
Sumit Arora
0b991bdc0f
feat(devtools): adding piechart for profiler
2020-03-18 15:41:56 -04:00
Sumit Arora
7990fdd7b3
style(devtools): adding control padding and bold title
2020-03-18 15:18:50 -04:00
Sumit Arora
257e231f68
style(devtools): fixing title style
2020-03-18 15:18:50 -04:00
Sumit Arora
7c93631b32
style(devtools): setting total time text to bold
2020-03-18 15:18:50 -04:00
AleksanderBodurri
e74e213b7c
refactor(devtools): clean up record formatter constants by removing duplicate objects
2020-03-18 09:31:25 -04:00
AleksanderBodurri
a5beefb477
feat(devtools): rerender tree on resize to keep tree within view
2020-03-18 09:31:25 -04:00
AleksanderBodurri
ae478f0e29
test(devtools): create simple unit test for webtreegraph formatter
2020-03-18 09:31:25 -04:00
AleksanderBodurri
45de7613e4
refactor(devtools): create mock formatter to sepearte getLabel and getValue tests from flamegraph;
2020-03-18 09:31:25 -04:00
AleksanderBodurri
18214a9b99
feat(devtools): create webtree graph formatter and pass the formatted data through to the web tree graph visualizer
2020-03-18 09:31:25 -04:00
AleksanderBodurri
0140dc2c8b
refactor(devtools): create formatter interface; move flamegraph formatting logic to class that implements interface
2020-03-18 09:31:25 -04:00
AleksanderBodurri
e86ffc1d86
test(devtools): write tests for record formatter
2020-03-18 09:31:25 -04:00
AleksanderBodurri
816974654c
refactor(devtools): organize file structure of profiler components
2020-03-18 09:31:25 -04:00
AleksanderBodurri
e7db0d3f78
feat(devtools): split apart visualizing views; create new components for each visualizer component
2020-03-18 09:31:25 -04:00
mgechev
e74dc9e70d
fix(devtools): make sure we dont access position of an undefined parent
2020-03-17 21:04:11 -04:00
mgechev
657c74151f
fix(devtools): dont leak flat and indexed nodes
2020-03-16 23:04:19 -04:00
mgechev
48c140038b
fix(devtools): refresh & reinitialize on navigation
2020-03-13 18:49:46 -07:00
AleksanderBodurri
5eed92e91c
fix(devtools): give breadcrumb container a z-index higher than 1 to prevent an issue where scrolling on the x-axis may inadvertently scroll the properties view tab
2020-03-12 10:00:07 -07:00
AleksanderBodurri
0649cc485d
fix(devtools): fix edge case where only one item is profiled and where no items are profiled
2020-03-11 15:39:45 -07:00
mgechev
5fe0d80d0c
fix(devtools): compatibility issues with google3
2020-03-11 12:48:31 -07:00
mgechev
becdcca64a
feat(devtools): add support for Angular elements
...
Currently, we only show which components are Angular elements. We don't visualize them in their position in the component tree, but only indicate with different coloring.
In the profiler we should also somehow show which tiles correspond to elements. We can discuss this further in rangle/angular-devtools#112 .
2020-03-11 09:53:34 -04:00
AleksanderBodurri
ef16144443
test(devtools): integration tests for node selection logic after change detection
2020-03-10 14:54:24 -07:00
AleksanderBodurri
9bdaa57a74
feat(devtools): create shared-utils project library to house functions and classes that can be used by any other project
2020-03-10 14:54:24 -07:00
AleksanderBodurri
2eaf29822f
refactor(devtools): use arrayEquals instead of converting to string and checking equality in expandParents method
2020-03-10 14:54:24 -07:00
AleksanderBodurri
0f4dd494f3
fix(devtools): reselect node if it changes position after change detection
2020-03-10 14:54:24 -07:00
AleksanderBodurri
5b10bf2e38
refactor(devtools): add tslint typing rule and fix tslint warnings
2020-03-10 09:50:00 -07:00
mgechev
50488f9380
fix(devtools): distinguish between items with and without children
...
The big was caused by the diffing logic. We weren't updating the `router-outlet` because we were getting the same instance. Although that is true, there's a special case when the same instance now has children, which should cause rerender of the item (it's not expandable).
2020-03-09 15:32:39 -04:00
mgechev
ce3fbd0426
refactor(devtools): remove obsolete test and fix existing e2e tests
2020-03-09 14:59:09 -04:00
mgechev
bcfd7b97d6
fix(devtools): align with latest changes and keep consistent frame tree
2020-03-09 14:59:09 -04:00
AleksanderBodurri
0babf20443
refactor(devtools): Use material dialog instead of browser confirm when profiler version is incorrect
2020-03-04 10:21:48 -08:00
AleksanderBodurri
dceb8d304c
feat(devtools): add versioning to import/export functionality
2020-03-04 10:21:48 -08:00
AleksanderBodurri
605214c59d
feat(devtools): implement import/export json functionality for profiler
2020-03-04 10:21:48 -08:00
AleksanderBodurri
466ecaf472
refactor(devtools): rename invalidArrowEvent method for damp-ness
2020-03-02 11:11:24 -10:00
AleksanderBodurri
a665e305ea
fix(devtools): allow arrow key events to fire when focusing on an input
2020-03-02 11:11:24 -10:00
AleksanderBodurri
b1d0f0a7d4
feat(devtools): add overflow-x auto to breadcrumbs tab
2020-03-02 09:07:49 -10:00
AleksanderBodurri
015d98e2c0
feat(devtools): decrease width of split pane to match the rest of the application
2020-02-28 10:00:53 -05:00
AleksanderBodurri
38afb5c90b
feat(devtools): Add margin to tree nodes so that they are not stacked on each other directly
2020-02-28 10:00:53 -05:00
AleksanderBodurri
eb3a1c2971
fix(devtools): fix issue where last node would be hidden behind breadcrumbs
2020-02-28 10:00:53 -05:00
AleksanderBodurri
6c284ef32e
fix(devtools tabs): stop scroll occuring at tabs level
2020-02-28 10:00:53 -05:00
AleksanderBodurri
4ea0d91dc5
feat(devtools): reorient split pane when screen width goes under 500 px
2020-02-28 10:00:53 -05:00
AleksanderBodurri
8d713657e7
test(devtools): add e2e testing for property editing feature
2020-02-26 15:35:50 -10:00
AleksanderBodurri
1fc39d9332
fix(devtools): fix issue that prevented booleans from being parsed properly
2020-02-26 15:35:50 -10:00
AleksanderBodurri
6727d7e229
fix(devtools): set a min width for the property view split tab to prevents styling issues when tab is too small
2020-02-26 15:35:50 -10:00
AleksanderBodurri
29db8d5a8b
feat(devtools): allow user to edit props
2020-02-26 15:35:50 -10:00
AleksanderBodurri
3b8833cfec
fix(devtools): use cascading view child/children to fix regression caused by refactor ( rangle/angular-devtools#92 )
2020-02-25 14:39:00 -05:00
AleksanderBodurri
edcaa8c89f
fix(devtools): stop filter input from scrolling with the component forest ( rangle/angular-devtools#87 )
2020-02-25 10:45:31 -05:00
AleksanderBodurri
5eba00abe5
fix(devtools): fix regression that broke node expansion ( rangle/angular-devtools#88 )
2020-02-25 10:36:02 -05:00
AleksanderBodurri
c5e633b8a3
refactor(devtools): refactor breadcrumbs into its own component. ( rangle/angular-devtools#90 )
2020-02-25 10:27:09 -05:00
AleksanderBodurri
984dfc6db1
fix(devtools): fix typo in file names ( rangle/angular-devtools#91 )
2020-02-25 07:44:22 -05:00