Kristiyan Kostadinov
d4ff6bc0b2
fix(compiler-cli): add warning for unused let declarations ( #57033 )
...
Adds a new extended diagnostic that will flag `@let` declarations that aren't used within the template. The diagnostic can be turned off through the `extendedDiagnostics` compiler option.
PR Close #57033
2024-07-23 08:27:17 -07:00
Andrew Scott
4ac39aeea9
Revert "fix(compiler-cli): add warning for unused let declarations ( #57033 )" ( #57088 )
...
This reverts commit c76b440ac0Close #57088
2024-07-22 15:28:03 -07:00
Kristiyan Kostadinov
c76b440ac0
fix(compiler-cli): add warning for unused let declarations ( #57033 )
...
Adds a new extended diagnostic that will flag `@let` declarations that aren't used within the template. The diagnostic can be turned off through the `extendedDiagnostics` compiler option.
PR Close #57033
2024-07-19 11:50:32 -07:00
Enea Jahollari
c8e2885136
feat(compiler): Add extended diagnostic to warn when there are uncalled functions in event bindings ( #56295 ) ( #56295 )
...
The diagnostic will catch issues like:
```html
<button (click)="increment"></button>
<button (click)="increment; decrement"></button>
<button (click)="true ? increment : decrement"></button>
<button (click)="nested.nested1.nested2.increment"></button>
```
PR Close #56295
(cherry picked from commit fd6cd0422dClose #56295
2024-07-03 15:36:39 +00:00
Jessica Janiuk
ec89fb6242
Revert "feat(compiler): Add extended diagnostic to warn when there are uncalled functions in event bindings ( #56295 )" ( #56810 )
...
This reverts commit fd6cd0422dClose #56810
2024-07-02 14:14:50 +00:00
Enea Jahollari
fd6cd0422d
feat(compiler): Add extended diagnostic to warn when there are uncalled functions in event bindings ( #56295 )
...
The diagnostic will catch issues like:
```html
<button (click)="increment"></button>
<button (click)="increment; decrement"></button>
<button (click)="true ? increment : decrement"></button>
<button (click)="nested.nested1.nested2.increment"></button>
```
PR Close #56295
2024-07-01 20:31:19 +00:00
Kristiyan Kostadinov
4d18c5bfd5
fix(compiler-cli): flag all conflicts between let declarations and local symbols ( #56752 )
...
Expands the check around conflicting `@let` declarations to also cover template variables and local references.
PR Close #56752
2024-07-01 14:03:57 +00:00
Kristiyan Kostadinov
9aea8a0576
refactor(compiler-cli): add diagnostic for duplicate let declarations ( #56199 )
...
Adds a template diagnostic that will flag cases where multiple `@let` declarations use the same name.
PR Close #56199
2024-06-04 17:28:03 +00:00
Kristiyan Kostadinov
695126453e
refactor(compiler-cli): integrate let declarations into the template type checker ( #56199 )
...
Integrates let declarations into the template type checker by producing corresponding constants in the TCB.
This also includes a couple of custom diagnostics to flag usages of let before they're declared and illegal writes to let declarations. We can't rely on TS for these checks, because it includes the variable name in the diagnostic.
PR Close #56199
2024-06-04 17:28:03 +00:00
Kristiyan Kostadinov
fb351300c3
build: update to latest dev infra code ( #56128 )
...
Updates the repo to the latest dev infra code which involves updating a patch and renaming all the golden files to end with `.api.md`.
PR Close #56128
2024-05-28 14:42:31 +02:00
