Commit graph

4473 commits

Author SHA1 Message Date
George Kalpakas
1c4d0ef1e1 build(docs-infra): fix e2e testing SystemJS-based docs examples (#41796)
This commits makes the SystemJS-based docs examples more self-contained
by ensuring the necessary WebDrivers are fetched before running the e2e
tests.
This is a follow-up to #41689. (See there for more discussion.)

PR Close #41796
2021-04-26 09:25:15 -07:00
George Kalpakas
04629c9f29 fix(docs-infra): fix external link icons positioning (#41794)
While trying to fix the appearance of `<code>` elements inside of
anchors with external URLs in #41694, the positioning of external link
icons was broken for anchors that would span multiple lines (see #41774
for details).

This commit fixes the positioning of external link icons, while still
preserving the correct appearance of `<code>` elements inside anchors
with external URLs.

NOTE:
Different types of links with external URLs can be seen in the following
docs sections:
- http://localhost:4200/docs#assumptions
- http://localhost:4200/guide/http#security-xsrf-protection
- http://localhost:4200/guide/workspace-config#generation-schematics

Fixes #41774

PR Close #41794
2021-04-26 09:24:06 -07:00
Kapunahele Wong
c0f62d044a docs: improve accessibility of architecture example (#41314)
PR Close #41314
2021-04-26 09:13:52 -07:00
Kapunahele Wong
2b4ab790b7 docs: make inputs-outputs example more accessible (#41288)
PR Close #41288
2021-04-26 09:12:20 -07:00
Kapunahele Wong
e1bc93fdb4 docs: improve accessibility of http example (#41057)
PR Close #41057
2021-04-26 09:11:09 -07:00
Sam Severance
49fae1f81d docs: Indicate HttpClientModule being imported (#41749)
PR Close #41749
2021-04-23 11:38:36 -07:00
George Kalpakas
17bae32271 build(docs-infra): upgrade cli command docs sources to 54ce436c9 (#41781)
Updating [angular#12.0.x](https://github.com/angular/angular/tree/12.0.x) from
[cli-builds#12.0.x](https://github.com/angular/cli-builds/tree/12.0.x).

##
Relevant changes in
[commit range](8a5dfd9bb...54ce436c9):

**Modified**
- help/build.json

PR Close #41781
2021-04-23 09:42:18 -07:00
Keen Yee Liau
4fd260d667 docs: Remove Protractor test from CI examples (#41733)
Protractor tests are no longer included in new projects starting from
Angular version 12.

PR Close #41733
2021-04-22 10:44:41 -07:00
George Kalpakas
6221227e10 build(docs-infra): upgrade cli command docs sources to 8a5dfd9bb (#41766)
Updating [angular#12.0.x](https://github.com/angular/angular/tree/12.0.x) from
[cli-builds#12.0.x](https://github.com/angular/cli-builds/tree/12.0.x).

##
Relevant changes in
[commit range](bdbc66133...8a5dfd9bb):

**Modified**
- help/build.json
- help/e2e.json
- help/generate.json
- help/new.json

PR Close #41766
2021-04-22 08:45:29 -07:00
Aristeidis Bampakos
ee610fdb46 docs: ident the library shematics guide properly (#41755)
PR Close #41755
2021-04-22 08:41:04 -07:00
George Kalpakas
7b0e25598a build(docs-infra): fix StackblitzBuilder after jsdom update (#41725)
In commit c617f1f768, `jsdom` was updated
from v9 to v16. This includes a breaking change that caused
`StackblitzBuilder` to fail to generate the StackBlitz examples.
However, this failure went unnoticed, because `StackblitzBuilder` still
completed successfully after failing to generate the examples. (This has
been fixed in the previous commit.)

This commit updates `StackblitzBuilder` to use the new `jsdom` API.

PR Close #41725
2021-04-22 08:38:23 -07:00
George Kalpakas
c2c83eb523 build(docs-infra): exit with an error code if generating StackBlitz examples fails (#41725)
Previously, failing to generate one or more StackBlitz examples would
log the errors but exit the command successfully. This made it easy to
miss such failures.

This commit fixes this by exiting the process with an error code if
generating one or more StackBlitz examples fails.
(In order to be able to see all potential errors, all examples are
attempted to be generated before exiting the process.)

PR Close #41725
2021-04-22 08:38:23 -07:00
Kapunahele Wong
e55ab5c418 docs: add instructions for opting into latest Language Service (#41600)
PR Close #41600
2021-04-21 17:29:08 -07:00
Kapunahele Wong
87b5026e48 docs: add margin to button boilerplate CSS for examples (#41413)
PR Close #41413
2021-04-20 11:37:30 -07:00
George Kalpakas
804a694c9e build(docs-infra): upgrade cli command docs sources to bdbc66133 (#41720)
Updating [angular#12.0.x](https://github.com/angular/angular/tree/12.0.x) from
[cli-builds#12.0.x](https://github.com/angular/cli-builds/tree/12.0.x).

##
Relevant changes in
[commit range](37b5f1c99...bdbc66133):

**Modified**
- help/build.json
- help/generate.json
- help/test.json

PR Close #41720
2021-04-20 09:43:20 -07:00
Daniel Díaz
dc9435044e docs: rewrites animation query () method use (#41710)
PR Close #41710
2021-04-20 09:40:31 -07:00
unknown
81907f6300 docs: add Material Design for Bootstrap to UI Component resources (#41702)
PR Close #41702
2021-04-20 09:39:17 -07:00
Oluwole Majiyagbe
bac3c85846 docs: add API CMS capability to Angular App resources (#40924)
PR Close #40924
2021-04-20 09:37:53 -07:00
Pete Bacon Darwin
2114a134fd build(docs-infra): update docs examples to Angular v11.2.10 (#41689)
This commit updates the docs examples to Angular v11.2.10. See the [diff between 11.0.1 and 11.2.10 (FW) and 11.2.9 (CLI)][1].

The changes are fairly trivial including:

- Removal of `emitDecoratorMetadata` from tsconfig.json files, where no JIT compilation is required.
- Setting `enableI18nLegacyMessageIdFormat` to `false` for CLI based applications - the i18n example was already migrated away from legacy message IDs.

[1]: https://github.com/cexbrayat/angular-cli-diff/compare/11.2.9..11.0.1

PR Close #41689
2021-04-19 14:18:52 -07:00
Pete Bacon Darwin
74578bc0f8 refactor(docs-infra): tidy up systemjs boilerplate for upgrade examples (#41689)
The ngUpgrade examples mostly rely upon SystemJS configuration.
This commit tidies up how these examples are built and tested so that
it will be easier to migrate them to work with Angular 11.2.x

PR Close #41689
2021-04-19 14:18:52 -07:00
Pete Bacon Darwin
7f44a4781b docs: migrate example to use non-legacy message IDs (#41689)
From 11.x, new projects are set up to use the latest message ID format.
This commit updates the i18n example project to stop using legacy IDs.

PR Close #41689
2021-04-19 14:18:51 -07:00
Renovate Bot
37ce86b546 build: update jsdom to version 16.5.3 (#41695)
PR Close #41695
2021-04-19 14:16:46 -07:00
Bendik Skarpnes
d95fa13343 docs: fix styling issues in example CSS (#41222)
PR Close #41222
2021-04-19 14:15:47 -07:00
Pierre Portejoie
884ff367ec docs: fix tutorial indicating the app is working when an error is actually displayed (#40732)
PR Close #40732
2021-04-19 14:15:01 -07:00
Amadou Sall
b027a48fb5 docs: add missing preposition in the animations guide (#41697)
PR Close #41697
2021-04-19 08:35:13 -07:00
George Kalpakas
4e8a4ee979 fix(docs-infra): fix code inside anchor elements with external URLs (#41694)
Previously, due to the `inline-flex` display style of anchor elements
with external URLs, `<code>` elements nested inside such anchor elements
would cause extra spacing between lines. An occurrence of this can be
seen in the [Angular workspace configuration][1] guide.

This commit fixes the problem by removing the `inline-flex` display
style (allowing anchor elements to fall back to the default `inline`
style).

For reference, the `inline-flex` style was introduced in commit
7944ee2c30 in order to avoid underlining
link icons. This style seems to no longer be necessary (either it was
never necessary or the underlying browser bug that made it necessary was
fixed).

Before: ![code links before][2]
After: ![code links after][3]

[1]: https://next.angular.io/guide/workspace-config#generation-schematics
[2]: https://user-images.githubusercontent.com/8604205/115149753-34589780-a06e-11eb-8d4e-825b5e94282d.png
[3]: https://user-images.githubusercontent.com/8604205/115149755-3589c480-a06e-11eb-9b15-825d75c74878.png

PR Close #41694
2021-04-19 08:32:11 -07:00
George Kalpakas
f51c6ff888 refactor(docs-infra): remove duplicate ol selector (#41694)
This commit removes a duplicate `ol` selector from `typography.scss`.

PR Close #41694
2021-04-19 08:32:11 -07:00
George Kalpakas
3a2c86c2a7 refactor(docs-infra): simplify regex in search WebWorker (#41693)
This commit simplifies a regex used in angular.io's search WebWorker. It
also updates some comments to add more context on what the code does.

PR Close #41693
2021-04-19 08:31:34 -07:00
Renovate Bot
ad69a53679 build: update jasmine-spec-reporter to version 7.0.0 (#41692)
PR Close #41692
2021-04-19 08:30:54 -07:00
Renovate Bot
e90bc598fd build: update image-size to version 1.0.0 (#41691)
PR Close #41691
2021-04-19 08:30:20 -07:00
George Kalpakas
d2906d2643 docs: replace hair space with regular space in creating-libraries.md (#41690)
This commit replaces a [hair space][1] with a regular space in
`creating-libraries.md`.
(You can see the hair space "in action" in the "Schematics for
Libraries" link right above the [Publishing your library][2] section.

[1]: https://en.wikipedia.org/wiki/Template:Hair_space
[2]: https://v10.angular.io/guide/creating-libraries#publishing-your-library

PR Close #41690
2021-04-19 08:29:47 -07:00
George Kalpakas
e5af4e9f58 docs: add missing backticks in schematics-for-libraries.md (#41681)
PR Close #41681
2021-04-19 08:26:38 -07:00
George Kalpakas
010e6d4341 test(docs-infra): change URL separator from \t to --> in URLS_TO_REDIRECT.txt (#41680)
Previously, the `URLS_TO_REDIRECT.txt` file was expected to separate
URLs by a `\t` character. This could easily been mistaken for a regular
space and would often result in test errors when updating the file.

This commit updates the `URLS_TO_REDIRECT.txt` file and the
corresponding test helpers to use `-->` (potentially surrounded by
whitespace) as a separator for the URLs. This also gives a hint about
the "from" --> "to" relationship of the redirect URL pair.

PR Close #41680
2021-04-19 08:26:04 -07:00
George Kalpakas
a5cadd7b6f test(docs-infra): ignore empty lines in URLS_TO_REDIRECT.txt (#41680)
Previously, the `URLS_TO_REDIRECT.txt` file was expected to not contain
any empty lines. This could easily result in test errors when updating
the file, since it is common for IDEs/editors to automatically ensure
there is an empty line at the end of a saved file
([example failure][1]).

This commit updates the test helpers to be able to cope with empty or
whitespace-only lines in `URLS_TO_REDIRECT.txt` by ignoring such lines.

[1]: https://circleci.com/gh/angular/angular/965534

PR Close #41680
2021-04-19 08:26:04 -07:00
Kirk Larkin
52053d0a97 docs: correct appUnless desc re true/false (#41656)
PR Close #41656
2021-04-19 08:23:13 -07:00
George Kalpakas
3efd5ae403 docs: fix broken links to CLI wiki in the "Component styles" guide (#41516)
Fixes #41362

PR Close #41516
2021-04-19 08:22:23 -07:00
va-stefanek
620aaf4d28 docs: change link to the styles configuration guide (#41516)
PR Close #41516
2021-04-19 08:22:23 -07:00
Eduard Bondarenko
88dd08c020 docs: move lazy loading section to the best practices section (#41378)
PR Close #41378
2021-04-16 17:27:02 -07:00
Gérôme Grignon
bc3a37ce0f docs: add mention to CSS styles for hero-detail (#41214)
PR Close #41214
2021-04-16 17:26:31 -07:00
sovtara
43bd580a38 docs: fix the property name in the example (#41410)
AppHighlight directive from the example doesn't have myHighlight attribute.
It only has appHighlight property. So we should use appHighlight instead of myHighlight.

PR Close #41410
2021-04-16 17:25:41 -07:00
Dharmen Shah
b24bb2ae71 docs: separate steps for github actions (#41594)
PR Close #41594
2021-04-16 17:25:04 -07:00
Dharmen Shah
0280150144 docs: add github actions in CI story (#41594)
PR Close #41594
2021-04-16 17:25:04 -07:00
Alan Agius
d6060539c0 test(docs-infra): run all example tests in IVY runtime (#41638) (#41662)
We have several tests which use system.js, this means that we cannot use NGCC with `--create-ivy-entry-points`, also we need to process UMD bundles since our system.js configurations use UMDs.

PR Close #41638

(cherry picked from commit d3edc5c0f5)

PR Close #41662
2021-04-16 09:26:18 -07:00
Alan Agius
542842580f build(docs-infra): update lite-server to fix errors on OSX (#41638) (#41662)
```
$ lite-server -c bs-config.aot.json
$ ngc -p tsconfig-aot.json && rollup -c rollup-config.js
/Users/xxxx/git/angular/aio/tools/examples/shared/node_modules/browser-sync/node_modules/chokidar/lib/fsevents-handler.js:26
  return (new fsevents(path)).on('fsevent', callback).start();
          ^
TypeError: fsevents is not a constructor
    at createFSEventsInstance (/Users/xxxx/git/angular/aio/tools/examples/shared/node_modules/browser-sync/node_modules/chokidar/lib/fsevents-handler.js:26:11)
    at setFSEventsListener (/Users/xxxx/git/angular/aio/tools/examples/shared/node_modules/browser-sync/node_modules/chokidar/lib/fsevents-handler.js:80:16)
    at FSWatcher.FsEventsHandler._watchWithFsEvents (/Users/xxxx/git/angular/aio/tools/examples/shared/node_modules/browser-sync/node_modules/chokidar/lib/fsevents-handler.js:244:16)
    at FSWatcher.<anonymous> (/Users/xxxx/git/angular/aio/tools/examples/shared/node_modules/browser-sync/node_modules/chokidar/lib/fsevents-handler.js:378:25)
    at LOOP (fs.js:1752:14)
    at processTicksAndRejections (internal/process/task_queues.js:79:11)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
completed: yarn serve:aot
```

PR Close #41638

(cherry picked from commit e920eac026)

PR Close #41662
2021-04-16 09:26:18 -07:00
Alan Agius
a1ff47c738 build(docs-infra): remove view engine related code (#41638) (#41662)
This is a pre-update to Angular 12 cleanup.

This is not needed for version 12, since applications cannot be built using View Engine.

PR Close #41638

(cherry picked from commit 70425539f7)

PR Close #41662
2021-04-16 09:26:18 -07:00
Renovate Bot
d1447d43e7 build: update angular packages (#41633)
PR Close #41633
2021-04-16 08:52:39 -07:00
Julien Marcou
16f41cd948 build: update TypeScript to v4.2.4 (#41620)
Update TypeScript to be consistent across different packages.

PR Close #41620
2021-04-16 08:51:55 -07:00
Teri Glover
c85710da4f docs: edits to remove jargon and abbreviations (#41530)
PR Close #41530
2021-04-15 16:00:56 -07:00
Teri Glover
9684cd36b1 docs: update copy in schematics.md (#41521)
PR Close #41521
2021-04-15 14:38:09 -07:00
Michael Hladky
e655846627 docs: add rx-angular to resources.json (#39291)
PR Close #39291
2021-04-14 15:50:47 -07:00