Commit graph

94 commits

Author SHA1 Message Date
AleksanderBodurri
3a6b5b0bd9 refactor(devtools): remove old unused methods from property tab body, client event subscribers, and directive property resolver 2020-03-22 19:59:30 -07:00
AleksanderBodurri
f8bb080157 feat(devtools): pass input/output data through from application to devtools UI 2020-03-22 19:59:30 -07:00
mgechev
4b40752cb9 refactor(devtools): type safe serialization 2020-03-22 03:59:27 -04:00
mgechev
b127cdc211 fix(devtools): prevent race condition between getting nested props and refresh 2020-03-21 19:09:12 -07:00
mgechev
b010784b21 fix(devtools): do not expand HTML Comments and preserve state for selected nodes 2020-03-21 19:09:12 -07:00
mgechev
5f5307e610 fix(devtools): flicker properties when update selected node
Fix rangle/angular-devtools#171

The PR includes few changes:
1. Fixes a race condition between two competing async calls
2. Simplifies the message bus, now we have one method for getting the component tree instead of one for getting the component tree and another for getting properties. Similarly to GraphQL we send a query for exactly what we need.
3. Fixes the way we update properties in the UI once we receive new items
2020-03-21 19:09:12 -07:00
Minko Gechev
6a6059d2b1 build(devtools): enable strictNullChecks (rangle/angular-devtools#167) 2020-03-20 11:54:37 -07:00
mgechev
48c140038b fix(devtools): refresh & reinitialize on navigation 2020-03-13 18:49:46 -07:00
AleksanderBodurri
1871c34743 fix(devtools): get ng debug object whenever it is required through a function to prevent an issue where it would be set to undefined on page refresh 2020-03-12 15:54:47 -07:00
mgechev
07344cd4b3 feat(devtools): implement "force refresh" when the user presses the refresh button 2020-03-12 15:13:34 -07:00
mgechev
57f6f26b52 refactor(devtools): add comments and remove useless npm scripts 2020-03-12 15:13:15 -07:00
mgechev
3340caf648 fix(devtools): show report for replaced nodes in the same tile and get lifecycle hook name 2020-03-12 15:13:15 -07:00
mgechev
82a8d5c0aa fix(devtools): show elements nested in app elements 2020-03-12 15:13:15 -07:00
mgechev
387b2f34fd refactor(devtools): show more meaningful warning message to help us debug cases 2020-03-12 15:13:15 -07:00
mgechev
6d86bbc11b fix(devtools): get the lifecycle hook name using a more robust approach 2020-03-12 15:13:15 -07:00
mgechev
e254d385f1 refactor(devtools): extract root components traversing the dom 2020-03-12 15:13:15 -07:00
mgechev
fc5801b225 fix(devtools): get the lview from the instance context 2020-03-12 15:13:15 -07:00
mgechev
5fe0d80d0c fix(devtools): compatibility issues with google3 2020-03-11 12:48:31 -07:00
mgechev
21f6b736f5 refactor(devtools): rename getComponentName to getDirectiveName 2020-03-11 12:48:31 -07:00
mgechev
30978b3718 fix(devtools): names of the tiles in the profiler graph 2020-03-11 12:48:31 -07:00
mgechev
becdcca64a feat(devtools): add support for Angular elements
Currently, we only show which components are Angular elements. We don't visualize them in their position in the component tree, but only indicate with different coloring.

In the profiler we should also somehow show which tiles correspond to elements. We can discuss this further in rangle/angular-devtools#112.
2020-03-11 09:53:34 -04:00
mgechev
7851fb2348 perf(devtools): do not index on mutation of inspector 2020-03-10 15:56:38 -04:00
AleksanderBodurri
5b10bf2e38 refactor(devtools): add tslint typing rule and fix tslint warnings 2020-03-10 09:50:00 -07:00
mgechev
ce3fbd0426 refactor(devtools): remove obsolete test and fix existing e2e tests 2020-03-09 14:59:09 -04:00
mgechev
bcfd7b97d6 fix(devtools): align with latest changes and keep consistent frame tree 2020-03-09 14:59:09 -04:00
mgechev
d6a0afc1d6 refactor(devtools): dont recompute directive forest frequently 2020-03-09 14:59:09 -04:00
mgechev
085232972e refactor(devtools): use different algorithm for observing the tree to align with the internal traversal 2020-03-09 14:59:09 -04:00
mgechev
c2dfa86702 refactor(devtools): use internal ivy data structures for extracting component tree 2020-03-09 14:59:09 -04:00
AleksanderBodurri
87aaa4933c fix(devtools): check if node.children is undefined before trying to convert it into an array (ex. node is a text node) 2020-03-05 09:54:18 -08:00
AleksanderBodurri
a30d2a5653 fix(devtools): index new nodes before firing callbacks to fix issue where some callbacks rely on the newly indexed nodes 2020-03-05 09:53:45 -08:00
AleksanderBodurri
9c4c18b8ef fix(devtools): fix bug in component tree observer that prevented nested added nodes from having their ids set properly 2020-03-04 10:21:02 -08:00
AleksanderBodurri
97915ba9fb refactor(devtools): type returns of insertion trie methods 2020-03-01 09:53:37 -10:00
Sumit Arora
d052ced086 test(devtools): adding highlighter tests 2020-02-27 14:33:48 -05:00
AleksanderBodurri
9510a1c38e fix(devtools): make edit functionality compatible with new getDirectiveForest api 2020-02-26 15:35:50 -10:00
AleksanderBodurri
29db8d5a8b feat(devtools): allow user to edit props 2020-02-26 15:35:50 -10:00
AleksanderBodurri
2025717a13 fix(devtools): check if node.nativeelement is an instance of an HTMLElement before calling ng.getComponent on it (rangle/angular-devtools#93) 2020-02-26 10:17:27 -05:00
AleksanderBodurri
dd977f4b26 fix(devtools): fix regression that broke assignment of selected node to $ng0 variable (rangle/angular-devtools#89) 2020-02-25 10:32:04 -05:00
mgechev
113e4cc72d refactor(devtools): address review comments 2020-02-24 11:09:10 -05:00
mgechev
c3a8fcb08a refactor(devtools): address review comments 2020-02-24 11:09:10 -05:00
mgechev
41cb658e10 fix(devtools): handle corner cases when a component aims to replace an existing one 2020-02-24 11:09:10 -05:00
mgechev
b46b296255 fix(devtools): get proper change detection trigger 2020-02-24 11:09:10 -05:00
mgechev
632a12579b fix(devtools): prevent node overwriting 2020-02-24 11:09:10 -05:00
mgechev
4b2c509b61 test(devtools): disable two specs temporarily 2020-02-24 11:09:10 -05:00
mgechev
570adcf2f5 fix(devtools): proper calculation of the lifecycle hook duration 2020-02-24 11:09:10 -05:00
mgechev
dba943a4e2 feat(devtools): detect directives added to non-elements 2020-02-24 11:09:10 -05:00
mgechev
8a286f1a07 fix(devtools): show proper lifecycle hook names 2020-02-24 11:09:10 -05:00
mgechev
23bc10cf7e fix(devtools): do not highlight nodes during initial rendering 2020-02-24 11:09:10 -05:00
mgechev
c44f00b78e feat(devtools): patch life cycle hooks 2020-02-24 11:09:10 -05:00
mgechev
a8088ac68f fix(devtools): proper timing for operations 2020-02-24 11:09:10 -05:00
mgechev
f454498274 fix(devtools): make sure we dont fail on null elements 2020-02-24 11:09:10 -05:00