Commit graph

434 commits

Author SHA1 Message Date
Matthieu Riegler
8d56b17b95 ci: exclude test files from primitives review
Those files aren't synced into G3 and shouldn't require external reviews

(cherry picked from commit bf8105ef76)
2026-04-01 20:27:31 +02:00
Joey Perrott
244e0b0b59 ci: correct capitalization of MarkTechson in pullapprove
Correct the capitalization of MarkTechson's username to match their GitHub profile, ensuring proper evaluation by PullApprove.

(cherry picked from commit 543753f551)
2026-03-23 14:50:23 -07:00
Matthieu Riegler
c499c578c9 ci: fix exclusion of manual_api_docs
On top of #67253, dev-infra should be required for docs files

(cherry picked from commit bf93ff83d8)
2026-03-09 23:27:47 +00:00
Matthieu Riegler
a86c3214c2 ci: update pullapprove for manual_api docs
The markdown files shouldn't require dev-infra approval.

(cherry picked from commit 0cd00b91ef)
2026-02-24 23:23:34 +00:00
Miles Malerba
02b7f5e4f7 ci: remove mmalerba from reviewers
remove mmalerba from reviewers

(cherry picked from commit 0af9e3e9ee)
2026-02-23 18:19:02 +00:00
Jessica Janiuk
87372893ea ci: update ng-dev config and pullapprove
This updates the pullapprove to remove the auto labeling of requires: TGP and instead moves it to the ng-dev config for pr updates.

(cherry picked from commit d7ddebca90)
2026-02-20 19:02:14 +00:00
marktechson
29a17ed791 docs: Adds new agent skills to Angular
The first agent skill is a workflow for building a new Angular app from scratch. Using this skill agents will use Angular tooling for code generation where appropriate. Also includes important hints.
2026-02-13 10:07:54 -08:00
Jessica Janiuk
4937d162f5 ci: update pullapprove reviewer list
This cleans up the pullapprove reviewers.
2026-02-11 14:00:01 -08:00
Miles Malerba
50e74add52
build: add skills in antigravity
Adds a symlink `.agent/skills` to `.gemini/skills`. This will allow
antrigravity which searches under `.agent` to see them.
2026-02-11 13:39:52 -08:00
Alan Agius
d019ee3c0b ci: add myself to pull approve dev-infra reviewers
Add myself to the dev-infra reviewers.
2026-02-09 12:22:18 -08:00
Matthieu Riegler
c69b67147a ci: add Charles & Doug as optional adev reviewers
Since we also have tooling docs...
2026-01-02 08:14:37 +01:00
Alan Agius
25bf417d57 ci: include dev-app files from pullapprove checks
At dev-app to pullaprove
2025-12-01 19:24:22 +01:00
Matthieu Riegler
98ceb0a80d ci: update pullapprove reviewers
Removing Minko from the pool of automatically picked reviewers
2025-11-24 13:25:26 -05:00
Matthieu Riegler
9dd7cc13ca ci: adding myself as optional to the compiler scope
For whenever I feel confortable approving compiler PRs like diagnostics
2025-11-24 12:18:26 -05:00
Joey Perrott
fe2cc7967e ci: use hardcoded global approvers group
Use a single hardcoded, within the pullapprove config file, group for global approvers instead of leveraging a github team as a group
2025-11-13 12:16:48 -08:00
Jan Martin
50ee2072f6 ci: update handle for jkrems/hybrist
The username was changed earlier today and the old username is no
longer in use.
2025-11-03 19:43:52 +00:00
Joey Perrott
497dce962d ci: update pullapprove config (#64086)
Update the pullapprove config to include vscode-ng-language-service

PR Close #64086
2025-09-25 14:34:41 -04:00
Alan Agius
950ffd001e build: remove yarn from integration tests, switch to pnpm (#63902)
This commit removes Yarn as a package manager for integration tests and migrates to pnpm. This change aims to standardize package management across the project, leveraging pnpm's efficiency and consistent behavior for dependency resolution and installation.

PR Close #63902
2025-09-18 14:39:51 +00:00
Paul Gschwendtner
4b2cc12bc4 ci: remove myself from unavailability (#63863)
Removes myself from unavailability.

PR Close #63863
2025-09-17 14:27:42 +00:00
Jessica Janiuk
de8be9784d ci: update pullapprove public-api rules (#63737)
This reduces the required reviews to 1 and requested reviewers to 2 to reduce friction.

PR Close #63737
2025-09-15 17:03:42 +00:00
Miles Malerba
16fa983989 ci: add more team members as approvers (#63495)
adds amishne, leonsenft, mattrbeck to approve but not receive review
requests

PR Close #63495
2025-08-29 15:12:13 -07:00
Matthieu Riegler
983cc2f6fd ci: add myself to review fw-general (#63337)
Also adding myself to be assigned some adev PRs

PR Close #63337
2025-08-22 12:27:36 -07:00
Paul Gschwendtner
6c8d000016 ci: mark myself as unavailable during OOO (#63214)
Marks myself as unavailable during OOO to not block reviews :)

PR Close #63214
2025-08-18 12:53:19 +02:00
Joey Perrott
82cc576e6f build: use pnpm as the package manager instead of yarn (#62924)
Use pnpm instead of yarn as the package manager and interaction tool for the repo

PR Close #62924
2025-07-31 22:06:27 +00:00
Joey Perrott
9888fc4966 build: remove the esm interop patches and tooling (#62879)
Remove esm interop patches and tooling from previous toolchain

PR Close #62879
2025-07-29 17:25:35 +00:00
Jessica Janiuk
743b928331 ci: update renovate reviewers (#62761)
This restores the framework-team availability, since the setting was not working as intended.

PR Close #62761
2025-07-23 07:24:13 -04:00
Joey Perrott
b0effa1cc3 ci: use new size tracking in integration tests (#62650)
Use the new size tracking within integration tests

PR Close #62650
2025-07-17 13:56:22 -04:00
Jessica Janiuk
bece163f87 ci: add to public-api approvers list (#62591)
This appends reviewers to the approvers list.

PR Close #62591
2025-07-11 10:43:27 -07:00
Jessica Janiuk
624195706d ci: adjust renovate teams (#62578)
This switches framework team to approve but not requested, and adds the currently active caretaker group to the teams for renovate.

PR Close #62578
2025-07-10 12:52:31 -07:00
Miles Malerba
c682dfffcd ci: add gemini code assist config (#62560)
Configures gemini to not interact with new pull requests, only review on
demand

PR Close #62560
2025-07-09 12:42:45 -07:00
Jessica Janiuk
aad1e747d6 ci: update pullapprove reviewers (#62448)
This sets some people to be reviewers, but not actively requested to account for availability.

PR Close #62448
2025-07-03 09:15:19 +00:00
Jan Martin
53575390f4 ci: add jkrems to pullapprove (public-api) (#62340)
Allow jkrems to (co-)approve public-api changes.

PR Close #62340
2025-06-27 18:37:00 +00:00
Jessica Janiuk
1bf1fb2ad7 ci: Update pullapprove ownership for compiler and zonejs (#62261)
This updates the zone.js owners and adds thePunderWoman to compiler approvers.

PR Close #62261
2025-06-25 12:46:40 +00:00
Paul Gschwendtner
579618d6d6 build: remove packages/bazel (#61843)
Removes the `@angular/bazel` package as we no longer need it. Yay!

It's replaced by `rules_angular`.

PR Close #61843
2025-06-04 09:13:41 +00:00
Doug Parker
2f0ecfc8ef refactor: expand DevTools reviewer list (#61709)
Updates the current list of DevTools reviewers to make a few small changes.
1. Adds `hawkgs` and `milomg`.
2. Removes the leading `~` from `JeanMeche` to include him in automatic review requests.
3. Adds `jkrems` for additional Googler coverage in automatic review requests.
4. Removes `mgechev` and `MarkTechson` who haven't been involved in daily DevTools development for a while.
5. Adds the leading `~` to `devversion` and `josephperrott` to remove them from automatic review requests while leaving them with access for "break glass" situations.

Note that the leading `~` means that the individual may approve PRs and satisfy the group's requirement, but PullApprove will not automatically request a review from them. See https://v3-docs.pullapprove.com/config/reviewers/#reviewers-that-dont-want-review-requests.

PR Close #61709
2025-05-30 09:56:09 -04:00
Paul Gschwendtner
032b802f54 build: remove irrelevant madge circular deps tests (#61156)
We don't need this tooling anymore because we are already validating
that there are no circular dependencies via the `ng-dev` tooling that
checks `.ts` files directly.

Also these tests never actually failed to my knowledge.

PR Close #61156
2025-05-07 11:28:59 -07:00
hawkgs
af67334fe5 ci: add hawkgs to pullapprove (#60536)
Add hawkgs to pullaprove for angular-dev.

PR Close #60536
2025-03-26 20:39:31 -07:00
Jessica Janiuk
3f0f2e65a8 ci: update shared primitives reviewers list (#60447)
This tightens up the list of reviewers for any shared primitives code changes.

PR Close #60447
2025-03-19 08:37:40 +01:00
Kristiyan Kostadinov
375b4ef5dc build: update public-api approvers (#60328)
Adds myself and Paul to the public API reviewers to help with the reviews.

PR Close #60328
2025-03-11 11:07:18 -07:00
Miles Malerba
f2d51c9ba2 build: remove circular deps goldens (#60021)
Removes the circular dependencies golden file and cleans up the
associated pullapprove group. All circular dependencies have been
removed and no new ones may be added.

PR Close #60021
2025-02-19 21:01:31 +00:00
Miles Malerba
c056fb9df9 ci: add mmalerba to pullapprove (#60005)
Add mmalerba to pullapprove config

PR Close #60005
2025-02-19 15:18:07 +00:00
Jessica Janiuk
d46aa79873 build: update zone.js pullapprove rule (#59942)
This fixes the broken pullapprove config due to a missing array.

PR Close #59942
2025-02-13 20:16:49 +00:00
Jessica Janiuk
d1a3e6203c build: update zone.js pullapprove rule (#59941)
This excludes lock and package files from requiring zones approval.

PR Close #59941
2025-02-13 19:17:13 +00:00
Andrew Scott
8ee91bceed build: remove self from unavailable list (#59858)
remove self from unavailable list

PR Close #59858
2025-02-05 12:18:57 -08:00
Pawel Kozlowski
3d1496274c ci: update Ethan Cline GitHub user name (#59516)
Use case-sensitive user name.

PR Close #59516
2025-01-14 10:52:04 -05:00
Ethan Cline
a648fa14dd ci: Add self (Ethan Cline) as primitives-shared reviewer. (#59437)
Add self (Ethan Cline) as primitives-shared reviewer.

PR Close #59437
2025-01-09 10:31:29 -05:00
Paul Gschwendtner
97039e8ce8 ci: remove devversion from unavailable pullapprove list (#59391)
Removing myself as I'm available for reviews.

PR Close #59391
2025-01-07 15:31:49 +00:00
Jessica Janiuk
2c3630aafd ci: consolidate pullapprove groups (#59080)
This change was originally proposed by @alxhub. We should all be comfortable reviewing and approving any and all code in the repo. This consolidation removes the barriers for that to happen.

PR Close #59080
2024-12-19 14:38:42 -07:00
Jessica Janiuk
f073bedda4 ci: add kirjs to pullapprove groups (#59025)
This adds Kirill to a number of pullapprove groups.

PR Close #59025
2024-12-03 18:31:37 +01:00
Paul Gschwendtner
7c628f9ee8 ci: mark devversion as unavailable (#59007)
Will be unavailable for a bit, and don't want to block review queue :)

PR Close #59007
2024-12-02 15:13:23 +01:00