arielbackenroth
34ded10fa6
fix(core): Fix a bug where snapshotted functions are being run twice if they return a nullish/falsey value. ( #59073 )
...
Snapshots can return nullish values; don't run the snapshotted function if the snapshotted function returns a nullish/falsey value.
PR Close #59073
2024-12-05 16:16:49 -08:00
Kristiyan Kostadinov
7e61217170
fix(compiler-cli): consider pre-release versions when detecting feature support ( #59061 )
...
Fixes that the logic which checks whether a feature is supported didn't account for pre-releases.
Fixes https://github.com/angular/vscode-ng-language-service/issues/2123 .
PR Close #59061
2024-12-05 16:15:12 -08:00
Kristiyan Kostadinov
cd764a3115
fix(compiler-cli): error in unused standalone imports diagnostic ( #59064 )
...
Fixes a null pointer error in the unused standalone imports diagnostic. It was caused by an inconsistency in TypeScript's built-in types.
Fixes #58872 .
PR Close #59064
2024-12-05 16:14:02 -08:00
Matthieu Riegler
ffae7df6e8
refactor(http): Don't log fetch warning in tests. ( #59049 )
...
Prior to this commit, we were logging the `NOT_USING_FETCH_BACKEND_IN_SSR` error when `provideHttpTestingClient` and `PLATFORM_ID` were provided.
fixes #59028
PR Close #59049
2024-12-05 16:12:55 -08:00
Charles Lyding
ae0802d63c
fix(platform-browser): collect external component styles from server rendering ( #59031 )
...
SSR generated component styles used in development environments will add
external styles via link elements to the HTML. However, the runtime would
previously not collect these link elements for reuse with rendered components.
This would result in two copies of the link elements present in the DOM. In
isolation this is not problematic as it is only present in development mode.
Unfortunately, the Vite-based CSS HMR functionality used by the Angular CLI
only updates the first stylesheet it finds and leaves other instances of the
stylesheet in place. This behavior causes the styles to be left in an
inconsistent state. This could be considered a defect within Vite as it should
update all relevant styles to maintain consistency but ideally there should
not be two instances in the Angular SSR case. To avoid the Vite issue, the
runtime will now collect SSR generated external styles and reuse them.
PR Close #59031
2024-12-05 16:12:22 -08:00
Sheik Althaf
044e1d8007
refactor(router): remove standalone true ( #58950 )
...
removed the standalone true from router package.
PR Close #58950
2024-12-05 16:02:37 -08:00
Alex Rickabaugh
1cd0eb83d2
refactor(router): remove circular dep in router navigation code ( #59083 )
...
Use `import type` to break phantom circular imports for the router
navigation implementation.
PR Close #59083
2024-12-05 16:01:16 -08:00
Alex Rickabaugh
9d73fe605e
refactor(router): remove circular dep in router model definitions ( #59083 )
...
Use `import type` to break phantom circular imports for router model
definitions.
PR Close #59083
2024-12-05 16:01:16 -08:00
Alex Rickabaugh
f87cdd9280
refactor(router): remove circular dep in RouterOutletContext ( #59083 )
...
Use `import type` to break phantom circular imports for
`RouterOutletContext`.
PR Close #59083
2024-12-05 16:01:16 -08:00
Alex Rickabaugh
308950dafa
refactor(core): remove circular dep in LView & LContainer definitions ( #59083 )
...
Use `import type` to break phantom circular imports in the runtime
definitions of `LView` and `LContainer`.
PR Close #59083
2024-12-05 16:01:15 -08:00
Alex Rickabaugh
8bc3693f7a
refactor(core): remove circular dep in JIT decorator definitions ( #59083 )
...
Use `import type` to break phantom circular imports in the runtime
definitions of JIT decorators.
PR Close #59083
2024-12-05 16:01:15 -08:00
Alex Rickabaugh
98471dfc08
refactor(core): remove circular dep in ComponentFactoryResolver ( #59083 )
...
Use `import type` to break a phantom circular import in the runtime
definition of `ComponentFactory` and `ComponentFactoryResolver`.
PR Close #59083
2024-12-05 16:01:15 -08:00
Alex Rickabaugh
850a2ad899
refactor(core): remove circular dep in DI code ( #59083 )
...
Use `import type` to break a phantom circular import in the DI code.
PR Close #59083
2024-12-05 16:01:15 -08:00
Alex Rickabaugh
c9ce08a7ea
refactor(core): remove circular dep in iterable differs. ( #59083 )
...
Use `import type` to break a phantom circular import in iterable differs.
PR Close #59083
2024-12-05 16:01:15 -08:00
Alex Rickabaugh
d0e0446149
refactor(core): remove circular dep in ViewRef definition ( #59083 )
...
Use `import type` to break a phantom circular import in the runtime
definition of `ViewRef`.
PR Close #59083
2024-12-05 16:01:15 -08:00
Alex Rickabaugh
b58123bfd8
refactor(compiler): remove circular dep in the output ast ( #59083 )
...
Use `import type` to break a phantom circular import in the output AST in
the compiler.
PR Close #59083
2024-12-05 16:01:15 -08:00
Alex Rickabaugh
3e8e9483db
refactor(compiler-cli): remove circular dep in the partial evaluator ( #59083 )
...
Use `import type` to break a phantom import cycle.
PR Close #59083
2024-12-05 16:01:15 -08:00
Tom Wilkinson
e2c8c6f269
refactor(core): Remove event_contract_multi_container ( #59059 )
...
This code has been moved internally.
PR Close #59059
2024-12-05 15:24:43 -08:00
Matthieu Riegler
a7fb45fba2
Revert "fix(platform-server): remove peer dependency on animations ( #58997 )" ( #59051 )
...
This reverts commit 1cfbfc66d3 .
PR Close #59051
2024-12-04 19:11:12 +01:00
hawkgs
e18adff76d
refactor(docs-infra): update comments ( #59004 )
...
Add missing file header comments and update others.
PR Close #59004
2024-12-04 18:06:00 +01:00
hawkgs
0c40bb28e1
refactor(docs-infra): convert code-example-s that have only region param to @example-s ( #59004 )
...
Replace all <code-example>-s within TS files that contain only a path and a region with JSDoc @example-s.
PR Close #59004
2024-12-04 18:06:00 +01:00
hawkgs
41a600f3ae
feat(docs-infra): include code examples files in the API gen ( #59004 )
...
The code examples in `package/examples` are now passed to the API JSON generator.
PR Close #59004
2024-12-04 18:05:59 +01:00
hawkgs
5f3ba068f1
docs: set syntax highlighting of code examples MD code blocks ( #59026 )
...
Set the syntax highlighting based on the code examples' language.
PR Close #59026
2024-12-04 17:30:28 +01:00
Sheik Althaf
0df7b1e0ed
refactor(common): remove standalone: true ( #58949 )
...
Removed the standalone true flag from common packages.
PR Close #58949
2024-12-04 12:41:51 +01:00
hawkgs
b8a2ae01d5
docs: fix missing alert block styles in the API reference ( #59020 )
...
Substitute legacy alert classes with the new ones.
PR Close #59020
2024-12-04 11:02:43 +01:00
Angular Robot
a107bf8ddb
build: update dependency mocha to v11 ( #59012 )
...
See associated pull request for more information.
PR Close #59012
2024-12-03 12:21:45 +01:00
Angular Robot
0fe3760626
build: lock file maintenance ( #58998 )
...
See associated pull request for more information.
PR Close #58998
2024-12-02 16:29:03 +01:00
Timon
c453f5dc2f
docs(core): fix eventCoalescing comment ( #57097 )
...
PR Close #57097
2024-12-02 11:34:27 +01:00
Kristiyan Kostadinov
f3c388ecda
fix(platform-server): remove peer dependency on animations ( #58997 )
...
The `@angular/platform-server` package had a peer dependency on `@angular/animations` which wasn't being used anywhere.
PR Close #58997
2024-12-02 11:33:05 +01:00
Kristiyan Kostadinov
4392ccedf9
fix(migrations): inject migration dropping code if everything except super is removed ( #58959 )
...
Fixes that in some cases the internal version of the migration was dropping code when all the statements after the `super` call are deleted.
PR Close #58959
2024-12-02 08:56:21 +01:00
Kristiyan Kostadinov
e17ff71c31
fix(migrations): don't migrate classes with parameters that can't be injected ( #58959 )
...
Updates the inject migrations to skip over classes that have uninjectable class parameters.
PR Close #58959
2024-12-02 08:56:21 +01:00
Kristiyan Kostadinov
9cbebc6dda
fix(migrations): preserve type literals and tuples in inject migrations ( #58959 )
...
Updates the inject migration to preserve type literals and tuple types, based on some internal feedback.
PR Close #58959
2024-12-02 08:56:21 +01:00
Kristiyan Kostadinov
7c5f990001
fix(migrations): inject migration aggressively removing imports ( #58959 )
...
Fixes that the inject migration would remove imports even if they're still used by classes that aren't being migrated.
PR Close #58959
2024-12-02 08:56:21 +01:00
Kristiyan Kostadinov
d1cbdd6acb
fix(migrations): correctly strip away parameters surrounded by comments in inject migration ( #58959 )
...
Fixes that the inject migration was sometimes producing invalid code if there are comments around the parameters.
PR Close #58959
2024-12-02 08:56:21 +01:00
Kristiyan Kostadinov
7b5bacc228
fix(migrations): class content being deleted in some edge cases ( #58959 )
...
Fixes that the inject migration was deleting the class' content if a property exists after the constructor that is being rewritten.
PR Close #58959
2024-12-02 08:56:21 +01:00
Kristiyan Kostadinov
b1828065f3
refactor(compiler): remove allowInvalidAssignmentEvents flag ( #58988 )
...
Deletes the `allowInvalidAssignmentEvents` which was added to facilitate a migration away from invalid two-way bindings. Since the migration doesn't exist anymore, we don't need the flag either.
PR Close #58988
2024-12-02 08:55:42 +01:00
Gustav Blomqvist
0a56d82900
docs(core): grammatical fix ( #58204 )
...
PR Close #58204
2024-11-28 17:38:35 +01:00
arturovt
e86b179a01
refactor(core): preventing resolving renderer factory every tick ( #58618 )
...
Prevents the `RendererFactory2` from being resolved each time the tick runs, as it only needs to be requested once.
PR Close #58618
2024-11-28 15:17:28 +01:00
Kristiyan Kostadinov
9f99196d23
fix(compiler-cli): account for multiple generated namespace imports in HMR ( #58924 )
...
The current HMR compiler assumes that there will only be one namespace import in the generated code (`@angular/core`). This is incorrect, because the compiler may need to generate additional imports in some cases (e.g. importing directives through a module). These changes adjust the compiler to capture all the namespaces in an array and pass them along.
Fixes #58915 .
PR Close #58924
2024-11-28 10:00:56 +01:00
arielbackenroth
4792db9a6d
fix(core): Explicitly manage TracingSnapshot lifecycle and dispose of it once it's been used. ( #58929 )
...
Provide a callback to the TracingService implementation when a Snapshot can be disposed.
The underlying tracing implementation may use refcounting and needs to release resources
to enable the trace to complete.
While change detection uses the snapshot for exactly one callback, after render runs
multiple hooks in the sequence so we need a more predictable way to indicate that the snapshot
can be finalized.s
PR Close #58929
2024-11-27 18:11:13 +01:00
Matthieu Riegler
8c49a14c6e
docs(docs-infra): remove unused api-examples ( #58885 )
...
PR Close #58885
2024-11-27 18:05:08 +01:00
Jessica Janiuk
d23a5d5cae
refactor(core): Consolidates shouldTrigger* methods down to one ( #58833 )
...
This cleans up the triggering code base and consolidates it down to one
function that outlines the logic. This also resolves the `hydrate when`
behavior issue.
fixes : #58709
PR Close #58833
2024-11-27 17:00:06 +01:00
Jessica Janiuk
d6da6313c1
refactor(compiler): Adds ingest and flags for defer details ( #58833 )
...
This adds TDeferDetailsFlags to indicate the presence of hydration triggers, and any future flags we add to defer.
PR Close #58833
2024-11-27 17:00:06 +01:00
Vincent
22a6ff788f
refactor(core): Make wording of effect-allowSignalWrites deprecation warning more accurate ( #58792 )
...
The previous warning contained a typo and also somewhat implied that allowSignalWrites did something. However, setting allowSignalWrites to false has no impact at all in Angular 19.
Closes #58790
PR Close #58792
2024-11-27 16:59:05 +01:00
Enea Jahollari
2e4e485655
refactor(docs-infra): use interpolation instead of innerHTML for better perf ( #58913 )
...
Using innerHTML will cause the browser to parse the HTML and then create a DOM tree instead of just using normal interpolation.
PR Close #58913
2024-11-27 10:59:18 +01:00
Utku Gultopu
4852e57d9a
docs: capitalize webpack with a lowercase W ( #56812 )
...
PR Close #56812
2024-11-26 22:24:11 +00:00
Alan Agius
552092d742
refactor(core): remove private whenStable ( #58891 )
...
The `@angular/ssr` package no longer depends on this symbol.
PR Close #58891
2024-11-26 18:10:51 +00:00
Jelle Bruisten
0c86d3e1f3
refactor(router): remove unused default error handler function ( #58819 )
...
with v19 the `defaultErrorHandler` has become unused, so could be removed
PR Close #58819
2024-11-26 14:49:37 +00:00
arielbackenroth
118803035f
fix(core): Ensure _tick is always run within the TracingSnapshot. ( #58881 )
...
Fix a bug where calls to _tick are called without running through the snapshot.
This helps ensure that all snapshots that are requested are resumed.
PR Close #58881
2024-11-25 21:19:52 +00:00
Andrew Kushnir
03a14b5034
refactor(core): invoke setActiveConsumer in ɵɵdeferHydrateWhen at the right time ( #58864 )
...
This commit updates the code of the `ɵɵdeferHydrateWhen` function to invoke the `setActiveConsumer` function at the right time (currently, we invoke it in the `finally` block, which is too late).
PR Close #58864
2024-11-25 16:12:37 +00:00