From feb6ee8f6e75d22944374ba1be4590e37e1990db Mon Sep 17 00:00:00 2001 From: Pawel Kozlowski Date: Fri, 10 Jun 2022 14:29:56 +0200 Subject: [PATCH] refactor(common): remove unnecessary toString conversions (#47082) A small refactor that removes explicit toString calls when not needed. PR Close #47082 --- .../ng_optimized_image/image_loaders/cloudflare_loader.ts | 2 +- .../ng_optimized_image/image_loaders/imagekit_loader.ts | 2 +- .../ng_optimized_image/image_loaders/imgix_loader.ts | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/common/src/directives/ng_optimized_image/image_loaders/cloudflare_loader.ts b/packages/common/src/directives/ng_optimized_image/image_loaders/cloudflare_loader.ts index 7b71b99d89d..0eb46ef1aae 100644 --- a/packages/common/src/directives/ng_optimized_image/image_loaders/cloudflare_loader.ts +++ b/packages/common/src/directives/ng_optimized_image/image_loaders/cloudflare_loader.ts @@ -30,7 +30,7 @@ function cloudflareLoaderFactory(path: string) { return (config: ImageLoaderConfig) => { let params = `format=auto`; if (config.width) { - params += `,width=${config.width.toString()}`; + params += `,width=${config.width}`; } const url = `${path}/cdn-cgi/image/${params}/${normalizeSrc(config.src)}`; return url; diff --git a/packages/common/src/directives/ng_optimized_image/image_loaders/imagekit_loader.ts b/packages/common/src/directives/ng_optimized_image/image_loaders/imagekit_loader.ts index 5e8a421cb79..977d1258f8b 100644 --- a/packages/common/src/directives/ng_optimized_image/image_loaders/imagekit_loader.ts +++ b/packages/common/src/directives/ng_optimized_image/image_loaders/imagekit_loader.ts @@ -36,7 +36,7 @@ export function imagekitLoaderFactory(path: string) { // https://ik.imagekit.io/demo/tr:w-300,h-300/medium_cafe_B1iTdD0C.jpg let params = `tr:q-auto`; // applies the "auto quality" transformation if (config.width) { - params += `,w-${config.width?.toString()}`; + params += `,w-${config.width}`; } const url = `${path}/${params}/${normalizeSrc(config.src)}`; return url; diff --git a/packages/common/src/directives/ng_optimized_image/image_loaders/imgix_loader.ts b/packages/common/src/directives/ng_optimized_image/image_loaders/imgix_loader.ts index 3957342705e..0a646f287b3 100644 --- a/packages/common/src/directives/ng_optimized_image/image_loaders/imgix_loader.ts +++ b/packages/common/src/directives/ng_optimized_image/image_loaders/imgix_loader.ts @@ -32,7 +32,9 @@ function imgixLoaderFactory(path: string) { const url = new URL(`${path}/${normalizeSrc(config.src)}`); // This setting ensures the smallest allowable format is set. url.searchParams.set('auto', 'format'); - config.width && url.searchParams.set('w', config.width.toString()); + if (config.width) { + url.searchParams.set('w', config.width.toString()); + } return url.href; }; }