From f57cd19e0c331b7187f503dbbc102791ab66529b Mon Sep 17 00:00:00 2001 From: Pete Bacon Darwin Date: Wed, 17 Feb 2021 20:45:56 +0000 Subject: [PATCH] refactor(localize): avoid computing source-maps in extraction unnecessarily (#40891) Previously we were calling `updateSourceLocations()` as part of `extractMessages()` for every file that was passed in, regardless of whether any `$localize` tagged strings were to be found in the file. This was very wasteful because it is non-trivial to compute the flattened source-map for files if it is not needed. PR Close #40891 --- packages/localize/src/tools/src/extract/extraction.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/localize/src/tools/src/extract/extraction.ts b/packages/localize/src/tools/src/extract/extraction.ts index 45144073a0d..3067bb7a2e9 100644 --- a/packages/localize/src/tools/src/extract/extraction.ts +++ b/packages/localize/src/tools/src/extract/extraction.ts @@ -58,9 +58,9 @@ export class MessageExtractor { code: false, ast: false }); - } - if (this.useSourceMaps) { - this.updateSourceLocations(filename, sourceCode, messages); + if (this.useSourceMaps && messages.length > 0) { + this.updateSourceLocations(filename, sourceCode, messages); + } } return messages; }