From f1bbbeab0cafb4cd7d0c2cc3ec7e27adc09a617c Mon Sep 17 00:00:00 2001 From: Pawel Kozlowski Date: Thu, 5 Sep 2024 11:40:19 +0200 Subject: [PATCH] test(migrations): add more tests to output migration (#57671) This change contains an additonal test that captures scenario of the problematic .pipe usage outside of the directive class. PR Close #57671 --- .../output-migration/output-migration.spec.ts | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/packages/core/schematics/migrations/output-migration/output-migration.spec.ts b/packages/core/schematics/migrations/output-migration/output-migration.spec.ts index 9849cb67c2b..741a3bfc7f1 100644 --- a/packages/core/schematics/migrations/output-migration/output-migration.spec.ts +++ b/packages/core/schematics/migrations/output-migration/output-migration.spec.ts @@ -174,6 +174,21 @@ describe('outputs', () => { `); }); + it('should _not_ migrate outputs that are used with .pipe outside of a component class', () => { + verifyNoChange(` + import {Directive, Output, EventEmitter} from '@angular/core'; + + @Directive() + export class TestDir { + @Output() someChange = new EventEmitter(); + } + + let instance: TestDir; + + instance.someChange.pipe(); + `); + }); + it('should _not_ migrate outputs that are used with .complete', () => { verifyNoChange(` import {Directive, Output, EventEmitter, OnDestroy} from '@angular/core';