Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(common): prevent reading chunks if app is destroyed (#61354)

Browse source 
Prevents processing response chunks after the application has been destroyed.

PR Close #61354
This commit is contained in:
arturovt 2025-05-15 01:59:33 +03:00 committed by Jessica Janiuk
parent c43fd3a39c
commit efda872453
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
packages/common/http/src/fetch.ts
View file

@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.dev/license
*/
import {inject, Injectable, InjectionToken, NgZone} from '@angular/core';
import {ApplicationRef, inject, Injectable, InjectionToken, NgZone} from '@angular/core';
import {Observable, Observer} from 'rxjs';
import {HttpBackend} from './backend';
@ -73,6 +73,7 @@ export class FetchBackend implements HttpBackend {
private readonly fetchImpl =
inject(FetchFactory, {optional: true})?.fetch ?? ((...args) => globalThis.fetch(...args));
private readonly ngZone = inject(NgZone);
private readonly appRef = inject(ApplicationRef);
handle(request: HttpRequest<any>): Observable<HttpEvent<any>> {
return new Observable((observer) => {
@ -152,6 +153,14 @@ export class FetchBackend implements HttpBackend {
// Here calling the async ReadableStreamDefaultReader.read() is responsible for triggering CD
await this.ngZone.runOutsideAngular(async () => {
while (true) {
// Prevent reading chunks if the app is destroyed. Otherwise, we risk doing
// unnecessary work or triggering side effects after teardown.
// This may happen if the app was explicitly destroyed before
// the response returned entirely.
if (this.appRef.destroyed) {
break;
}
const {done, value} = await reader.read();
if (done) {