Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(core): capture stack for HMR errors (#60067)

Browse source 
Currently we send the `message` of an error thrown during HMR. That's usually not enough so now we also capture the stack trace.

Relates to https://github.com/angular/angular-cli/issues/29695.

PR Close #60067
This commit is contained in:
Kristiyan Kostadinov 2025-02-23 09:28:03 +01:00 committed by kirjs
parent 9c5a6a6442
commit ebfbaeba54
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/core/src/render3/hmr.ts
View file

@ -308,12 +308,13 @@ function executeWithInvalidateFallback(
try {
callback();
} catch (e) {
const errorMessage = (e as {message?: string}).message;
const error = e as {message?: string; stack?: string};
// If we have all the necessary information and APIs to send off the invalidation
// request, send it before rethrowing so the dev server can decide what to do.
if (id !== null && errorMessage) {
importMeta?.hot?.send?.('angular:invalidate', {id, message: errorMessage, error: true});
if (id !== null && error.message) {
const toLog = error.message + (error.stack ? '\n' + error.stack : '');
importMeta?.hot?.send?.('angular:invalidate', {id, message: toLog, error: true});
}
// Throw the error in case the page doesn't get refreshed.