From e894a5daea401b4e1173b0e66557ae40140eb9a0 Mon Sep 17 00:00:00 2001
From: AleksanderBodurri <alexbodurri1117@gmail.com>
Date: Mon, 25 Nov 2024 01:46:19 -0500
Subject: [PATCH] feat(core): set kind field on template and effect nodes
 (#58865)

Builds on #58333 by assigning the kind field to reactive nodes that are not in the `core/primitives` package.

PR Close #58865
---
 packages/core/src/render3/reactive_lview_consumer.ts | 2 ++
 packages/core/src/render3/reactivity/effect.ts       | 1 +
 2 files changed, 3 insertions(+)

diff --git a/packages/core/src/render3/reactive_lview_consumer.ts b/packages/core/src/render3/reactive_lview_consumer.ts
index b38e721de1b..a58df64adf2 100644
--- a/packages/core/src/render3/reactive_lview_consumer.ts
+++ b/packages/core/src/render3/reactive_lview_consumer.ts
@@ -51,6 +51,7 @@ export function maybeReturnReactiveLViewConsumer(consumer: ReactiveLViewConsumer
 const REACTIVE_LVIEW_CONSUMER_NODE: Omit<ReactiveLViewConsumer, 'lView'> = {
   ...REACTIVE_NODE,
   consumerIsAlwaysLive: true,
+  kind: 'template',
   consumerMarkedDirty: (node: ReactiveLViewConsumer) => {
     markAncestorsForTraversal(node.lView!);
   },
@@ -80,6 +81,7 @@ export function getOrCreateTemporaryConsumer(lView: LView): ReactiveLViewConsume
 const TEMPORARY_CONSUMER_NODE = {
   ...REACTIVE_NODE,
   consumerIsAlwaysLive: true,
+  kind: 'template',
   consumerMarkedDirty: (node: ReactiveLViewConsumer) => {
     let parent = getLViewParent(node.lView!);
     while (parent && !viewShouldHaveReactiveConsumer(parent[TVIEW])) {
diff --git a/packages/core/src/render3/reactivity/effect.ts b/packages/core/src/render3/reactivity/effect.ts
index fb945c691ac..a427fbc2a49 100644
--- a/packages/core/src/render3/reactivity/effect.ts
+++ b/packages/core/src/render3/reactivity/effect.ts
@@ -245,6 +245,7 @@ export const BASE_EFFECT_NODE: Omit<EffectNode, 'fn' | 'destroy' | 'injector' |
     hasRun: false,
     cleanupFns: undefined,
     zone: null,
+    kind: 'effect',
     onDestroyFn: noop,
     run(this: EffectNode): void {
       this.dirty = false;