From ddfc833df9e40d9c427c0300a41e195e5e398767 Mon Sep 17 00:00:00 2001 From: SkyZeroZx <73321943+SkyZeroZx@users.noreply.github.com> Date: Mon, 2 Feb 2026 12:48:17 -0500 Subject: [PATCH] refactor(common): improve image directive typings Add image directive typings to improve type safety and removes an unused parameter from the observer registration. --- goldens/public-api/common/index.api.md | 2 +- .../src/directives/ng_optimized_image/lcp_image_observer.ts | 2 +- .../src/directives/ng_optimized_image/ng_optimized_image.ts | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/goldens/public-api/common/index.api.md b/goldens/public-api/common/index.api.md index f3defb0135d..0c4103c9880 100644 --- a/goldens/public-api/common/index.api.md +++ b/goldens/public-api/common/index.api.md @@ -639,7 +639,7 @@ export class NgOptimizedImage implements OnInit, OnChanges { static ngAcceptInputType_priority: unknown; // (undocumented) static ngAcceptInputType_width: unknown; - ngOnChanges(changes: SimpleChanges): void; + ngOnChanges(changes: SimpleChanges): void; ngOnInit(): void; ngSrc: string; ngSrcset: string; diff --git a/packages/common/src/directives/ng_optimized_image/lcp_image_observer.ts b/packages/common/src/directives/ng_optimized_image/lcp_image_observer.ts index b94dc1225de..0de0e1a7573 100644 --- a/packages/common/src/directives/ng_optimized_image/lcp_image_observer.ts +++ b/packages/common/src/directives/ng_optimized_image/lcp_image_observer.ts @@ -92,7 +92,7 @@ export class LCPImageObserver implements OnDestroy { return observer; } - registerImage(rewrittenSrc: string, originalNgSrc: string, isPriority: boolean) { + registerImage(rewrittenSrc: string, isPriority: boolean) { if (!this.observer) return; const newObservedImageState: ObservedImageState = { priority: isPriority, diff --git a/packages/common/src/directives/ng_optimized_image/ng_optimized_image.ts b/packages/common/src/directives/ng_optimized_image/ng_optimized_image.ts index 44739451e3a..8dd9a3ad89e 100644 --- a/packages/common/src/directives/ng_optimized_image/ng_optimized_image.ts +++ b/packages/common/src/directives/ng_optimized_image/ng_optimized_image.ts @@ -283,7 +283,7 @@ export class NgOptimizedImage implements OnInit, OnChanges { /** * Calculate the rewritten `src` once and store it. * This is needed to avoid repetitive calculations and make sure the directive cleanup in the - * `ngOnDestroy` does not rely on the `IMAGE_LOADER` logic (which in turn can rely on some other + * `DestroyRef.onDestroy` does not rely on the `IMAGE_LOADER` logic (which in turn can rely on some other * instance that might be already destroyed). */ private _renderedSrc: string | null = null; @@ -454,7 +454,7 @@ export class NgOptimizedImage implements OnInit, OnChanges { assertNoLoaderParamsWithoutLoader(this, this.imageLoader); ngZone.runOutsideAngular(() => { - this.lcpObserver!.registerImage(this.getRewrittenSrc(), this.ngSrc, this.priority); + this.lcpObserver!.registerImage(this.getRewrittenSrc(), this.priority); }); if (this.priority) { @@ -523,7 +523,7 @@ export class NgOptimizedImage implements OnInit, OnChanges { } /** @docs-private */ - ngOnChanges(changes: SimpleChanges) { + ngOnChanges(changes: SimpleChanges) { if (ngDevMode) { assertNoPostInitInputChange(this, changes, [ 'ngSrcset',