From dc8280d950f900060d39dcf6bcc3b3e07c54500a Mon Sep 17 00:00:00 2001 From: Andrew Kushnir Date: Mon, 6 Jan 2025 09:11:50 -0800 Subject: [PATCH] Revert "refactor(platform-server): reduce timeout used in tests (#59275)" (#59380) This reverts commit 19ec8266d1ef01ff59dfad55bc54e0f83bb87e67. PR Close #59380 --- .../test/incremental_hydration_spec.ts | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/packages/platform-server/test/incremental_hydration_spec.ts b/packages/platform-server/test/incremental_hydration_spec.ts index 9b720c17397..44e0c8b4665 100644 --- a/packages/platform-server/test/incremental_hydration_spec.ts +++ b/packages/platform-server/test/incremental_hydration_spec.ts @@ -65,8 +65,8 @@ function dynamicImportOf(type: T, timeout = 0): Promise { * Helper function to await all pending dynamic imports * emulated using `dynamicImportOf` function. */ -function allPendingDynamicImports(timeout?: number) { - return dynamicImportOf(null, timeout ?? 10); +function allPendingDynamicImports() { + return dynamicImportOf(null, 101); } describe('platform-server partial hydration integration', () => { @@ -2364,12 +2364,10 @@ describe('platform-server partial hydration integration', () => { location = inject(Location); } - const dynamicImportTimeout = 5; // ms - const deferDepsInterceptor = { intercept() { return () => { - return [dynamicImportOf(DeferredCmp, dynamicImportTimeout)]; + return [dynamicImportOf(DeferredCmp, 100)]; }; }, }; @@ -2399,12 +2397,10 @@ describe('platform-server partial hydration integration', () => { const routeLink = doc.getElementById('route-link')!; routeLink.click(); - // Wait a bit longer than a timeout used to emulate a dynamic import. - await allPendingDynamicImports(dynamicImportTimeout * 2); + await allPendingDynamicImports(); appRef.tick(); - // Wait a bit longer than a timeout used to emulate a dynamic import. - await allPendingDynamicImports(dynamicImportTimeout * 2); + await allPendingDynamicImports(); await appRef.whenStable(); expect(location.path()).toBe('/other/thing/stuff');