Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(devtools): rename state to properties (rangle/angular-devtools#682)

Browse source
This commit is contained in:
Emma Twersky 2021-04-14 11:52:26 -07:00 committed by GitHub
parent c5445440bf
commit da0ce975f8
4 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cypress/integration/node-search.e2e.js
View file

@ -83,7 +83,7 @@ describe('Search items in component tree', () => {
checkComponentName('app-todos');
// should display correct title for properties panel
cy.get('ng-property-view-header').should('have.text', 'Properties of app-todos ');
cy.get('ng-property-view-header').should('have.text', 'app-todos');
// should show correct component properties
cy.get('ng-property-view').find('mat-tree-node');

10
cypress/integration/property-edit.e2e.js
View file

@ -14,7 +14,7 @@ describe('edit properties of directive in the property view tab', () => {
getBody().find('app-todo input.edit').should('not.be.visible');
});
cy.get('.explorer-panel:contains("Properties of app-todo")')
cy.get('.explorer-panel:contains("app-todo")')
.find('ng-property-view mat-tree-node:contains("editMode")')
.find('ng-property-editor .editor')
.click({ force: true })
@ -31,9 +31,7 @@ describe('edit properties of directive in the property view tab', () => {
describe('edit todo property', () => {
beforeEach(() => {
// expand todo state
cy.get('.explorer-panel:contains("Properties of app-todo")')
.find('ng-property-view mat-tree-node:contains("todo")')
.click();
cy.get('.explorer-panel:contains("app-todo")').find('ng-property-view mat-tree-node:contains("todo")').click();
});
it('should change todo label in app when edited', () => {
@ -43,7 +41,7 @@ describe('edit properties of directive in the property view tab', () => {
});
// find label variable and run through edit logic
cy.get('.explorer-panel:contains("Properties of app-todo")')
cy.get('.explorer-panel:contains("app-todo")')
.find('ng-property-view mat-tree-node:contains("label")')
.find('ng-property-editor .editor')
.click()
@ -65,7 +63,7 @@ describe('edit properties of directive in the property view tab', () => {
});
// find completed variable and run through edit logic
cy.get('.explorer-panel:contains("Properties of app-todo")')
cy.get('.explorer-panel:contains("app-todo")')
.find('ng-property-view mat-tree-node:contains("completed")')
.find('ng-property-editor .editor')
.click()

2
projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab/property-tab-body/property-view/property-view-body/property-view-body.component.ts
View file

@ -35,7 +35,7 @@ export class PropertyViewBodyComponent {
controls: this.directiveOutputControls,
},
{
title: 'State',
title: 'Properties',
hidden: this.directiveStateControls.dataSource.data.length === 0,
controls: this.directiveStateControls,
},

2
projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab/property-tab-body/property-view/property-view-header/property-view-header.component.html
View file

@ -1 +1 @@
<mat-toolbar>Properties of {{ directive }} </mat-toolbar>
<mat-toolbar>{{ directive }}</mat-toolbar>