From d7283bf740840dcaea0ca75bc08319fbf1cd7113 Mon Sep 17 00:00:00 2001 From: Yong Su Date: Tue, 22 Oct 2024 16:02:55 -0700 Subject: [PATCH] refactor(core): allow passing passive option to addEvent (#58316) For scroll-blocking events like 'touchstart', 'touchmove', 'wheel' and 'mousewheel', if passive option is not specified when adding the event listener, browser may give a violation warning. This PR allows us to set the passive option when calling event lib's addEvent(). PR Close #58316 --- .../public-api/core/primitives/event-dispatch/index.api.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/goldens/public-api/core/primitives/event-dispatch/index.api.md b/goldens/public-api/core/primitives/event-dispatch/index.api.md index 4081472ded5..32dea535b04 100644 --- a/goldens/public-api/core/primitives/event-dispatch/index.api.md +++ b/goldens/public-api/core/primitives/event-dispatch/index.api.md @@ -28,7 +28,7 @@ export interface EarlyJsactionDataContainer { // @public export class EventContract implements UnrenamedEventContract { constructor(containerManager: EventContractContainerManager); - addEvent(eventType: string, prefixedEventType?: string): void; + addEvent(eventType: string, prefixedEventType?: string, passive?: boolean): void; cleanUp(): void; ecrd(dispatcher: Dispatcher, restriction: Restriction): void; handler(eventType: string): EventHandler | undefined; @@ -42,7 +42,7 @@ export class EventContract implements UnrenamedEventContract { // @public export class EventContractContainer implements EventContractContainerManager { constructor(element: Element); - addEventListener(eventType: string, getHandler: (element: Element) => (event: Event) => void): void; + addEventListener(eventType: string, getHandler: (element: Element) => (event: Event) => void, passive?: boolean): void; cleanUp(): void; // (undocumented) readonly element: Element;