From cd20dd07ce05e841d609bfa59457f3cf03edce49 Mon Sep 17 00:00:00 2001 From: Sam Severance Date: Fri, 1 May 2026 10:04:58 -0400 Subject: [PATCH] refactor(forms): improve clarity in SelectMultipleControlValueAccessor.writeValue Rename the _optionMap forEach parameter from `o` to `id` and tighten its type from `any` to `string`, removing the now-redundant `.toString()` call. --- .../directives/select_multiple_control_value_accessor.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/forms/src/directives/select_multiple_control_value_accessor.ts b/packages/forms/src/directives/select_multiple_control_value_accessor.ts index cd93b4f1cd1..65cc8e29af5 100644 --- a/packages/forms/src/directives/select_multiple_control_value_accessor.ts +++ b/packages/forms/src/directives/select_multiple_control_value_accessor.ts @@ -126,15 +126,15 @@ export class SelectMultipleControlValueAccessor */ writeValue(value: any): void { this.value = value; - let optionSelectedStateSetter: (opt: ɵNgSelectMultipleOption, o: any) => void; + let optionSelectedStateSetter: (opt: ɵNgSelectMultipleOption, id: string) => void; if (Array.isArray(value)) { // convert values to ids const ids = value.map((v) => this._getOptionId(v)); - optionSelectedStateSetter = (opt, o) => { - opt._setSelected(ids.indexOf(o.toString()) > -1); + optionSelectedStateSetter = (opt, id) => { + opt._setSelected(ids.indexOf(id) > -1); }; } else { - optionSelectedStateSetter = (opt, o) => { + optionSelectedStateSetter = (opt) => { opt._setSelected(false); }; }