Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(compiler-cli): update set of required inputs

Browse source 
Updates the required inputs that can be ignored for form controls.

(cherry picked from commit 877678345a)
This commit is contained in:
Kristiyan Kostadinov 2025-11-07 06:56:48 +01:00 committed by Andrew Kushnir
parent cc25f96f02
commit c81620f2c1
1 changed files with 30 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
packages/compiler-cli/src/ngtsc/typecheck/src/type_check_block.ts
View file

@ -747,26 +747,12 @@ class TcbGenericDirectiveTypeWithAnyParamsOp extends TcbDirectiveTypeOpBase {
abstract class TcbFieldDirectiveTypeBaseOp extends TcbOp {
/** Bindings that aren't supported on signal form fields. */
protected readonly unsupportedBindingFields = new Set([
// Should be kept in sync with the `FormUiControl` bindings,
// defined in `packages/forms/signals/src/api/control.ts`.
...formControlInputFields,
'value',
'checked',
'errors',
'invalid',
'disabled',
'disabledReasons',
'name',
'readonly',
'touched',
'max',
'maxlength',
'maxLength',
'min',
'minLength',
'minlength',
'pattern',
'required',
'type',
'maxlength',
'minlength',
]);
constructor(
@ -3144,10 +3130,14 @@ class Scope {
if (allDirectiveMatches.some(isFieldDirective)) {
const customFieldType = getCustomFieldDirectiveType(dir);
if (customFieldType === 'value') {
ignoredRequiredInputs = new Set(['value']);
} else if (customFieldType === 'checkbox') {
ignoredRequiredInputs = new Set(['checked']);
if (customFieldType !== null) {
ignoredRequiredInputs = new Set(formControlInputFields);
if (customFieldType === 'value') {
ignoredRequiredInputs.add('value');
} else if (customFieldType === 'checkbox') {
ignoredRequiredInputs.add('checked');
}
}
}
@ -4124,6 +4114,25 @@ function hasModel(name: string, meta: TypeCheckableDirectiveMeta): boolean {
);
}
/** Names of the input fields on custom controls. */
const formControlInputFields = [
// Should be kept in sync with the `FormUiControl` bindings,
// defined in `packages/forms/signals/src/api/control.ts`.
'errors',
'invalid',
'disabled',
'disabledReasons',
'name',
'readonly',
'touched',
'max',
'maxLength',
'min',
'minLength',
'pattern',
'required',
] as const;
function getCustomFieldDirectiveType(
meta: TypeCheckableDirectiveMeta,
): 'value' | 'checkbox' | null {