fix(devtools): fix incorrect logic in destroy function for ChromeMessageBus

Destroy uses window.removeEventListener but the ChromeMessageBus doesn't actually depend on a window object.

In practice this code is unlikely to ever be reached. If a tab is closed the entire context script JS process is killed so this is not an bug that would be very common or even reachable. That being said for correctness this should not be using window.

(cherry picked from commit 36edf4870f)
This commit is contained in:
Aleksander Bodurri 2026-03-23 00:18:00 -04:00 committed by Leon Senft
parent 244e0b0b59
commit c7a18924a6

View file

@ -80,7 +80,7 @@ export class ChromeMessageBus extends MessageBus<Events> {
}
override destroy(): void {
this._listeners.forEach((l) => window.removeEventListener('message', l));
this._listeners.forEach((l) => this._port.onMessage.removeListener(l));
this._listeners = [];
}
}