From c73aee21f33fd61ca9844791900dbd467e86bbe4 Mon Sep 17 00:00:00 2001 From: Jessica Janiuk Date: Thu, 5 Dec 2024 13:25:20 -0500 Subject: [PATCH] ci: consolidate pullapprove groups (#59080) This change was originally proposed by @alxhub. We should all be comfortable reviewing and approving any and all code in the repo. This consolidation removes the barriers for that to happen. PR Close #59080 --- .pullapprove.yml | 410 +++++------------------------------------------ 1 file changed, 42 insertions(+), 368 deletions(-) diff --git a/.pullapprove.yml b/.pullapprove.yml index 1f867f83d6a..22217c82f95 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -111,24 +111,6 @@ overrides: explanation: 'Passing as globally approved by global approvers' groups: - # ========================================================= - # Framework: Animations - # ========================================================= - fw-animations: - <<: *defaults - conditions: - - > - contains_any_globs(files, [ - 'packages/animations/**/{*,.*}', - 'packages/platform-browser/animations/**/{*,.*}', - ]) - reviewers: - users: - - alxhub - - crisbeto - - ~jelbourn - - thePunderWoman - # ========================================================= # Framework: Compiler # ========================================================= @@ -140,7 +122,8 @@ groups: 'packages/compiler/**/{*,.*}', 'packages/examples/compiler/**/{*,.*}', 'packages/compiler-cli/**/{*,.*}', - ]) + 'packages/language-service/**/{*,.*}', + ]) reviewers: users: - alxhub @@ -148,279 +131,53 @@ groups: - atscott - crisbeto - devversion + - kirjs - JoostK # ========================================================= - # Framework: Migrations + # Framework: General (most code in our packages) # ========================================================= - fw-migrations: - <<: *defaults - conditions: - - files.include("packages/core/schematics/*") - reviewers: - users: - - alxhub - - crisbeto - - devversion - - thePunderWoman - - AndrewKushnir - - # ========================================================= - # Framework: Core - # ========================================================= - fw-core: + fw-general: <<: *defaults conditions: - > - contains_any_globs(files.exclude("packages/core/schematics/*").exclude('packages/core/primitives/*'), [ - 'packages/core/**/{*,.*}', - 'packages/examples/core/**/{*,.*}', - 'packages/platform-browser/**/{*,.*}', - 'packages/examples/platform-browser/**/{*,.*}', - 'packages/platform-browser-dynamic/**/{*,.*}', - 'packages/docs/**/{*,.*}', - ]) - reviewers: - users: - - alxhub - - AndrewKushnir - - atscott - - crisbeto - - devversion - - thePunderWoman - - pkozlowski-opensource - - kirjs - - # ========================================================= - # Framework: Common - # ========================================================= - fw-common: - <<: *defaults - conditions: - - > - contains_any_globs(files.exclude("packages/common/http/*"), [ + contains_any_globs(files.exclude('packages/core/primitives/*'), [ + 'contributing-docs/public-api-surface.md', + 'goldens/circular-deps/packages.json', + 'integration/**/{*,.*}', + 'modules/**/{*,.*}', + 'packages/animations/**/{*,.*}', + 'packages/benchpress/**/{*,.*}', 'packages/common/**/{*,.*}', - 'packages/examples/common/**/{*,.*}', - ]) - reviewers: - users: - - alxhub - - AndrewKushnir - - atscott - - thePunderWoman - - pkozlowski-opensource - - kirjs - - # ========================================================= - # Framework: Http - # ========================================================= - fw-http: - <<: *defaults - conditions: - - > - contains_any_globs(files, [ - 'packages/common/http/**/{*,.*}', - 'packages/examples/http/**/{*,.*}', - ]) - reviewers: - users: - - alxhub - - AndrewKushnir - - atscott - - thePunderWoman - - pkozlowski-opensource - - kirjs - - # ========================================================= - # Framework: Elements - # ========================================================= - fw-elements: - <<: *defaults - conditions: - - > - contains_any_globs(files, [ + 'packages/core/**/{*,.*}', + 'packages/docs/**/{*,.*}', 'packages/elements/**/{*,.*}', - ]) - reviewers: - users: - - alxhub - - AndrewKushnir - - andrewseguin - - atscott - - thePunderWoman - - pkozlowski-opensource - - kirjs - - # ========================================================= - # Framework: Forms - # ========================================================= - fw-forms: - <<: *defaults - conditions: - - > - contains_any_globs(files, [ + 'packages/examples/**/{*,.*}', 'packages/forms/**/{*,.*}', - 'packages/examples/forms/**/{*,.*}', - ]) - reviewers: - users: - - AndrewKushnir - - alxhub - - # ========================================================= - # Framework: i18n - # ========================================================= - fw-i18n: - <<: *defaults - conditions: - - > - contains_any_globs(files, [ - 'packages/core/src/i18n/**/{*,.*}', - 'packages/core/src/render3/i18n/**/{*,.*}', - 'packages/core/src/render3/instructions/i18n.ts', - 'packages/core/src/render3/interfaces/i18n.ts', - 'packages/common/locales/**/{*,.*}', - 'packages/common/src/i18n/**/{*,.*}', - 'packages/common/src/pipes/date_pipe.ts', - 'packages/common/src/pipes/i18n_plural_pipe.ts', - 'packages/common/src/pipes/i18n_select_pipe.ts', - 'packages/common/src/pipes/number_pipe.ts', - 'packages/compiler/src/i18n/**/{*,.*}', - 'packages/compiler/src/render3/view/i18n/**/{*,.*}', - 'packages/compiler-cli/src/extract_i18n.ts', 'packages/localize/**/{*,.*}', - ]) - reviewers: - users: - - AndrewKushnir - - dgp1130 - - # ========================================================= - # Framework: Platform Server - # ========================================================= - fw-platform-server: - <<: *defaults - conditions: - - > - contains_any_globs(files, [ + 'packages/misc/**/{*,.*}', + 'packages/platform-browser/**/{*,.*}', + 'packages/platform-browser-dynamic/**/{*,.*}', 'packages/platform-server/**/{*,.*}', 'packages/ssr/**/{*,.*}', - ]) - reviewers: - users: - - alan-agius4 - - alxhub - - AndrewKushnir - - atscott - - thePunderWoman - - pkozlowski-opensource - - # ========================================================= - # Framework: Router - # ========================================================= - fw-router: - <<: *defaults - conditions: - - > - contains_any_globs(files, [ 'packages/router/**/{*,.*}', - 'packages/examples/router/**/{*,.*}', - ]) - reviewers: - users: - - AndrewKushnir - - atscott - - # ========================================================= - # Framework: Service Worker - # ========================================================= - fw-service-worker: - <<: *defaults - conditions: - - > - contains_any_globs(files, [ 'packages/service-worker/**/{*,.*}', - 'packages/examples/service-worker/**/{*,.*}', - ]) - reviewers: - users: - - alxhub - - # ========================================================= - # Framework: Upgrade - # ========================================================= - fw-upgrade: - <<: *defaults - conditions: - - > - contains_any_globs(files, [ 'packages/upgrade/**/{*,.*}', - 'packages/common/upgrade/**/{*,.*}', - 'packages/examples/upgrade/**/{*,.*}', - ]) - reviewers: - users: - - alxhub - - thePunderWoman - - # ========================================================= - # Framework: Testing - # ========================================================= - fw-testing: - <<: *defaults - conditions: - - > - contains_any_globs(files.exclude('packages/compiler-cli/*').exclude('packages/language-service/*').exclude('packages/service-worker/*').exclude('packages/core/schematics/*'), [ - 'packages/**/testing/**/{*,.*}', - ]) + ]) reviewers: users: - alxhub - AndrewKushnir - atscott - - thePunderWoman - - pkozlowski-opensource + - crisbeto + - devversion - kirjs - - # ========================================================= - # Framework: Benchmarks - # ========================================================= - fw-benchmarks: - <<: *defaults - conditions: - - > - contains_any_globs(files, [ - 'modules/benchmarks/**/{*,.*}', - 'modules/ssr-benchmarks/**/{*,.*}' - ]) - reviewers: - users: - - alxhub - - AndrewKushnir - - atscott + - ~jelbourn - thePunderWoman - pkozlowski-opensource # ========================================================= - # Framework: Playground - # ========================================================= - fw-playground: - <<: *defaults - conditions: - - > - contains_any_globs(files, [ - 'modules/playground/**/{*,.*}' - ]) - reviewers: - users: - - alxhub - - AndrewKushnir - - atscott - - thePunderWoman - - pkozlowski-opensource - - # ========================================================= - # Framework: Security + # Framework: Security-sensitive files which require extra review # ========================================================= fw-security: <<: *defaults @@ -434,6 +191,8 @@ groups: 'packages/tsconfig-tsec-base.json', 'packages/tsec-exemption.json', 'tools/tsec.bzl', + 'adev/src/content/guide/security.md', + 'adev/src/content/examples/security/**/{*,.*}', ]) reviewers: users: @@ -461,22 +220,6 @@ groups: - devversion - josephperrott - # ========================================================= - # Language Service - # ========================================================= - language-service: - <<: *defaults - conditions: - - > - contains_any_globs(files, [ - 'packages/language-service/**/{*,.*}', - ]) - reviewers: - users: - - alxhub - - atscott - - clydin - # ========================================================= # zone.js # ========================================================= @@ -491,77 +234,6 @@ groups: users: - JiaLiPassion - # ========================================================= - # in-memory-web-api - # ========================================================= - in-memory-web-api: - conditions: - - > - contains_any_globs(files, [ - 'packages/misc/angular-in-memory-web-api/**/{*,.*}', - ]) - reviewers: - users: - - alxhub - - AndrewKushnir - - atscott - - crisbeto - - thePunderWoman - - pkozlowski-opensource - - # ========================================================= - # Benchpress - # ========================================================= - benchpress: - <<: *defaults - conditions: - - > - contains_any_globs(files, [ - 'packages/benchpress/**/{*,.*}' - ]) - reviewers: - users: - - devversion - - josephperrott - - pkozlowski-opensource - - # ========================================================= - # Integration Tests - # ========================================================= - integration-tests: - <<: *defaults - conditions: - - > - contains_any_globs(files, [ - 'integration/**/{*,.*}' - ]) - reviewers: - users: - - alxhub - - AndrewKushnir - - atscott - - thePunderWoman - - josephperrott - - kirjs - - # ========================================================= - # Docs: Packaging, Tooling, Releasing - # ========================================================= - docs-packaging-and-releasing: - <<: *defaults - conditions: - - > - contains_any_globs(files, [ - 'contributing-docs/public-api-surface.md', - ]) - reviewers: - users: - - alxhub - - AndrewKushnir - - atscott - - thePunderWoman - - jelbourn - # ========================================================= # Tooling: Compiler API shared with Angular CLI # @@ -586,30 +258,32 @@ groups: reviewed_for: required # ========================================================= - # Docs: Angular Dev Site + # Documentation content # ========================================================= angular-dev: <<: *defaults conditions: - > contains_any_globs(files, [ - 'adev/**/{.*,*}', - 'aio/**/{.*,*}' - ]) + 'adev/**/{*,.*}', + ]) reviewers: users: - - josephperrott - - jelbourn - - bencodezen - - thePunderWoman - - AndrewKushnir + - alan-agius4 - alxhub - - crisbeto - - devversion + - AndrewKushnir - atscott - - pkozlowski-opensource - - MarkTechson + - bencodezen + - crisbeto + - kirjs - ~JeanMeche + - jelbourn + - thePunderWoman + - devversion + - josephperrott + - pkozlowski-opensource + - mgechev + - MarkTechson - kirjs # ========================================================= @@ -707,7 +381,7 @@ groups: - > contains_any_globs(files.exclude("goldens/public-api/manage.js"), [ 'goldens/public-api/**/{*,.*}', - ]) + ]) reviewers: users: - AndrewKushnir @@ -786,7 +460,7 @@ groups: - > contains_any_globs(files, [ '.pullapprove.yml' - ]) + ]) reviewers: users: - alxhub