From bb628d8b50801d85331ec4f14dd1997fd0bc6ac5 Mon Sep 17 00:00:00 2001 From: Alan Agius <17563226+alan-agius4@users.noreply.github.com> Date: Thu, 12 Mar 2026 09:07:32 +0000 Subject: [PATCH] refactor: ensure modules with 'declare global' are correctly handled by Rollup Explicitly adding an `export {}` to modules containing `declare global` fixes an issue where Rollup would incorrectly claim that the `global` variable is not defined in the emitted `.d.ts` files. Needed to land the latest `rules_angular`. --- .../core/primitives/event-dispatch/src/earlyeventcontract.ts | 3 +++ .../core/primitives/event-dispatch/src/event_dispatcher.ts | 3 +++ packages/core/primitives/signals/src/formatter.ts | 3 +++ packages/core/src/util/ng_dev_mode.ts | 3 +++ 4 files changed, 12 insertions(+) diff --git a/packages/core/primitives/event-dispatch/src/earlyeventcontract.ts b/packages/core/primitives/event-dispatch/src/earlyeventcontract.ts index 3d37b5dc4d5..cd81ea90cad 100644 --- a/packages/core/primitives/event-dispatch/src/earlyeventcontract.ts +++ b/packages/core/primitives/event-dispatch/src/earlyeventcontract.ts @@ -140,3 +140,6 @@ function removeEventListeners( container.removeEventListener(eventTypes[i], earlyEventHandler, /* useCapture */ capture); } } + +// This fixes the RollupError: Exported variable "global" is not defined. +export {}; diff --git a/packages/core/primitives/event-dispatch/src/event_dispatcher.ts b/packages/core/primitives/event-dispatch/src/event_dispatcher.ts index 27f32a1d7ac..a549e3d8b92 100644 --- a/packages/core/primitives/event-dispatch/src/event_dispatcher.ts +++ b/packages/core/primitives/event-dispatch/src/event_dispatcher.ts @@ -190,3 +190,6 @@ export function registerDispatcher( dispatcher.dispatch(eventInfo); }, Restriction.I_AM_THE_JSACTION_FRAMEWORK); } + +// This fixes the RollupError: Exported variable "global" is not defined. +export {}; diff --git a/packages/core/primitives/signals/src/formatter.ts b/packages/core/primitives/signals/src/formatter.ts index 101532954ce..19ceefec8dc 100644 --- a/packages/core/primitives/signals/src/formatter.ts +++ b/packages/core/primitives/signals/src/formatter.ts @@ -159,3 +159,6 @@ export function installDevToolsSignalFormatter() { globalThis.devtoolsFormatters.push(formatter); } } + +// This fixes the RollupError: Exported variable "global" is not defined. +export {}; diff --git a/packages/core/src/util/ng_dev_mode.ts b/packages/core/src/util/ng_dev_mode.ts index 9462b853d7c..79522085eee 100644 --- a/packages/core/src/util/ng_dev_mode.ts +++ b/packages/core/src/util/ng_dev_mode.ts @@ -90,3 +90,6 @@ export function initNgDevMode(): boolean { } return false; } + +// This fixes the RollupError: Exported variable "global" is not defined. +export {};