From b85d48c7d2e5c0fd183db5da8a4eb34ce2ede69c Mon Sep 17 00:00:00 2001 From: mgechev Date: Mon, 11 Oct 2021 11:10:59 -0700 Subject: [PATCH] refactor(devtools): use safe operation to update the overlay --- projects/ng-devtools-backend/src/lib/highlighter.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/projects/ng-devtools-backend/src/lib/highlighter.ts b/projects/ng-devtools-backend/src/lib/highlighter.ts index 1637adb27f5..9547ca0c32b 100644 --- a/projects/ng-devtools-backend/src/lib/highlighter.ts +++ b/projects/ng-devtools-backend/src/lib/highlighter.ts @@ -1,7 +1,7 @@ import { Type } from '@angular/core'; let overlay: any; -let overlayContent: any; +let overlayContent: HTMLElement; declare const ng: any; @@ -120,7 +120,11 @@ function showOverlay( overlay.style.top = ~~top + 'px'; overlay.style.left = ~~left + 'px'; - overlayContent.innerHTML = ''; + while (overlayContent.children.length) { + const { children } = overlayContent; + overlayContent.removeChild(children[children.length - 1]); + } + content.forEach((child) => overlayContent.appendChild(child)); document.body.appendChild(overlay);