From b3fca32a7979fc8d0a5ce4f4ae7ca44551ed1dfe Mon Sep 17 00:00:00 2001 From: Matthieu Riegler Date: Sat, 17 Dec 2022 23:18:21 +0100 Subject: [PATCH] refactor(common): remove unnecessary parseFloat from ng_optimized_image directive. (#48527) There is no need to parse clientWidth/clientHeight/naturalWidth/naturalHeight on HTMLImageElement as there is no sign of other types being returned on everygreen browers. PR Close #48527 --- .../ng_optimized_image/ng_optimized_image.ts | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/packages/common/src/directives/ng_optimized_image/ng_optimized_image.ts b/packages/common/src/directives/ng_optimized_image/ng_optimized_image.ts index 02008eb0bc7..aa760ec9f8e 100644 --- a/packages/common/src/directives/ng_optimized_image/ng_optimized_image.ts +++ b/packages/common/src/directives/ng_optimized_image/ng_optimized_image.ts @@ -775,16 +775,13 @@ function assertNoImageDistortion( dir: NgOptimizedImage, img: HTMLImageElement, renderer: Renderer2) { const removeListenerFn = renderer.listen(img, 'load', () => { removeListenerFn(); - // TODO: `clientWidth`, `clientHeight`, `naturalWidth` and `naturalHeight` - // are typed as number, but we run `parseFloat` (which accepts strings only). - // Verify whether `parseFloat` is needed in the cases below. - const renderedWidth = parseFloat(img.clientWidth as any); - const renderedHeight = parseFloat(img.clientHeight as any); + const renderedWidth = img.clientWidth; + const renderedHeight = img.clientHeight; const renderedAspectRatio = renderedWidth / renderedHeight; const nonZeroRenderedDimensions = renderedWidth !== 0 && renderedHeight !== 0; - const intrinsicWidth = parseFloat(img.naturalWidth as any); - const intrinsicHeight = parseFloat(img.naturalHeight as any); + const intrinsicWidth = img.naturalWidth; + const intrinsicHeight = img.naturalHeight; const intrinsicAspectRatio = intrinsicWidth / intrinsicHeight; const suppliedWidth = dir.width!; @@ -888,7 +885,7 @@ function assertNonZeroRenderedHeight( dir: NgOptimizedImage, img: HTMLImageElement, renderer: Renderer2) { const removeListenerFn = renderer.listen(img, 'load', () => { removeListenerFn(); - const renderedHeight = parseFloat(img.clientHeight as any); + const renderedHeight = img.clientHeight; if (dir.fill && renderedHeight === 0) { console.warn(formatRuntimeError( RuntimeErrorCode.INVALID_INPUT,