From a8139f77eabbe7dcc05cd8922ebeaa44be1eda02 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Tue, 28 Jan 2025 11:10:37 +0000 Subject: [PATCH] ci: configure merge tool to enforce mandatory PR statuses (#59749) The merge tool is currently hard-coded to only check `lint` as a required status. This was added because at some point the old GitHub robot was replaced with a so-called `unified-statuses` check GitHub action; but that one never worked/impacted productivity of the team. I've added support to the merge tool to require specific jobs/checks to run, before allowing merge (can be forcibly ignored). We are using this ability now to enforce a few "common" required jobs, as a safety measure when GitHub didn't trigger CI runs (e.g. for new contributors). This recently became a more prominent issue as the GitHub org enforces that CI doesn't run for e.g. first time contributors. PR Close #59749 --- .ng-dev/pull-request.mts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.ng-dev/pull-request.mts b/.ng-dev/pull-request.mts index 344c28e3185..237ea813ec9 100644 --- a/.ng-dev/pull-request.mts +++ b/.ng-dev/pull-request.mts @@ -22,4 +22,12 @@ export const pullRequest: PullRequestConfig = { assertEnforceTested: true, assertIsolatedSeparateFiles: true, }, + + requiredStatuses: [ + {type: 'check', name: 'test'}, + {type: 'check', name: 'lint'}, + {type: 'check', name: 'adev'}, + {type: 'check', name: 'zone-js'}, + {type: 'status', name: 'google-internal-tests'}, + ], };