From a588b2f712d68046aa613587f3ea616dd484a649 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Sun, 3 Jul 2022 10:21:35 +0000 Subject: [PATCH] ci: remove renovate changes group (#46676) Removes the Renovate changes group as the respective code-owners. i.e. dev-infra or docs-infra should be responsible for reviewing changes. The caretaker does not necessarily have context when e.g. Jasmine should be updated or not/ if this needs coordination with other parts of the organization etc. Also updates are not always trivial, see recent updates for Angular (involing size updates, CLI commands fixups etc.) and e.g. Karma-Jasmine requiring debugging of ZoneJS. The Renovate group is also not easy to keep now that we use a custom robot account that doesn't necessarily only do Renovate.. (we could check the branch name -- but I believe the group can just be removed) PR Close #46676 --- .pullapprove.yml | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/.pullapprove.yml b/.pullapprove.yml index 785b72ac82e..490253c78e0 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -118,20 +118,6 @@ overrides: explanation: 'Passing as globally approved by global approvers' groups: - # ========================================================= - # Renovate PRs - # - # All renovate PRs will be assigned to the current - # caretakers for review. - # ========================================================= - renovate-changes: - <<: *defaults - conditions: - - author in ["renovate[bot]"] - reviewers: - teams: - - angular-caretaker - # ========================================================= # Framework: Animations # =========================================================