Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix(zone.js): add missing APIs to Node.js fs patch (#54396)

Browse source 
This commit updates the list of Node.js `fs` APIs to be patched because
they haven't been updated for a long time. It adds `opendir,lutimes,writev`.
For example, the `opendir` method was added to Node.js in version 12.12.0 in
2019, causing some of the APIs to potentially be always called within the
`<root>` context.

**Note:** There are missing unit tests for these changes because in unit tests,
`fs` is patched by Bazel's Node.js rules and its `node_patches.cjs`. However,
the APIs are successfully patched in the real production code and are called
with the correct context.

PR Close #54396
This commit is contained in:
arturovt 2024-02-12 18:35:20 +02:00 committed by Andrew Kushnir
parent 58a8f124b0
commit 9e07b621ea
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/zone.js/lib/node/fs.ts
View file

@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/
import {patchMacroTask, zoneSymbol} from '../common/utils';
import {patchMacroTask} from '../common/utils';
import {ZoneType} from '../zone-impl';
export function patchFs(Zone: ZoneType): void {
@ -36,11 +36,13 @@ export function patchFs(Zone: ZoneType): void {
'futimes',
'lchmod',
'lchown',
'lutimes',
'link',
'lstat',
'mkdir',
'mkdtemp',
'open',
'opendir',
'read',
'readdir',
'readFile',
@ -55,6 +57,7 @@ export function patchFs(Zone: ZoneType): void {
'utimes',
'write',
'writeFile',
'writev',
];
TO_PATCH_MACROTASK_METHODS.filter(