From 9d3ced663600a46aff493a2af850588d7e72086e Mon Sep 17 00:00:00 2001 From: Alex Rickabaugh Date: Thu, 5 Dec 2024 13:16:15 -0800 Subject: [PATCH] refactor(core): remove circular dep in LView & LContainer definitions (#59083) Use `import type` to break phantom circular imports in the runtime definitions of `LView` and `LContainer`. PR Close #59083 --- goldens/circular-deps/packages.json | 4 ---- packages/core/src/render3/interfaces/view.ts | 3 +-- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/goldens/circular-deps/packages.json b/goldens/circular-deps/packages.json index 65007b257c6..6ae617cc54e 100644 --- a/goldens/circular-deps/packages.json +++ b/goldens/circular-deps/packages.json @@ -1,8 +1,4 @@ [ - [ - "packages/core/src/render3/interfaces/container.ts", - "packages/core/src/render3/interfaces/view.ts" - ], [ "packages/router/src/directives/router_outlet.ts", "packages/router/src/router_outlet_context.ts" diff --git a/packages/core/src/render3/interfaces/view.ts b/packages/core/src/render3/interfaces/view.ts index d6a091fc290..9a22a958927 100644 --- a/packages/core/src/render3/interfaces/view.ts +++ b/packages/core/src/render3/interfaces/view.ts @@ -13,11 +13,10 @@ import {ProviderToken} from '../../di/provider_token'; import {DehydratedView} from '../../hydration/interfaces'; import {SchemaMetadata} from '../../metadata/schema'; import {Sanitizer} from '../../sanitization/sanitizer'; -import type {AfterRenderManager} from '../after_render/manager'; import type {ReactiveLViewConsumer} from '../reactive_lview_consumer'; import type {ViewEffectNode} from '../reactivity/effect'; -import {LContainer} from './container'; +import type {LContainer} from './container'; import { ComponentDef, ComponentTemplate,