Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test(router): Update timeouts to reduce firefox flakiness (#62141)

Browse source 
This updates the timeouts in a couple flakey router tests. Ideally we can use the jasmine
auto ticking as soon as tests are migrated to web test runner and we are on the latest
version of jasmine

PR Close #62141
This commit is contained in:
Andrew Scott 2025-06-18 16:24:43 -07:00 committed by Andrew Kushnir
parent f11b3f9d2e
commit 9cc7c5f38e
2 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/router/test/integration/guards.spec.ts
View file

@ -1835,15 +1835,11 @@ export function guardsIntegrationSuite() {
let log: string[];
const guard1 = () => {
return delayObservable(5).pipe(tap({next: () => log.push('guard1')}));
return delayObservable(15).pipe(tap({next: () => log.push('guard1')}));
};
const guard2 = () => {
return delayObservable(0).pipe(tap({next: () => log.push('guard2')}));
};
const returnFalse = () => {
log.push('returnFalse');
return false;
};
const returnFalseAndNavigate = () => {
log.push('returnFalseAndNavigate');
inject(Router).navigateByUrl('/redirected');
@ -1851,7 +1847,7 @@ export function guardsIntegrationSuite() {
};
const returnUrlTree = () => {
const router = inject(Router);
return delayObservable(14).pipe(
return delayObservable(30).pipe(
mapTo(router.parseUrl('/redirected')),
tap({next: () => log.push('returnUrlTree')}),
);

4
packages/router/test/router_preloader.spec.ts
View file

@ -826,7 +826,7 @@ describe('RouterPreloader', () => {
lazyComponentSpy.and.returnValue(
of(LoadedComponent).pipe(
switchMap((v) => new Promise((r) => setTimeout(r, 10)).then(() => v)),
switchMap((v) => new Promise((r) => setTimeout(r, 50)).then(() => v)),
),
);
@ -867,7 +867,7 @@ describe('RouterPreloader', () => {
expect(getLoadedComponent(baseRoute)).not.toBeDefined();
expect(getLoadedRoutes(childRoutes![0])).toBeDefined();
await timeout(10);
await timeout(50);
expect(getLoadedComponent(baseRoute)).toBeDefined();
});