From 9c3f8d52d89918fcb78301e981aff6b4ffb092fb Mon Sep 17 00:00:00 2001 From: Alan Agius Date: Thu, 9 Mar 2023 12:21:06 +0000 Subject: [PATCH] ci: disable system js tests (#49332) These are currently broken due to the APF v16 changes which dropped support for ES2015. PR Close #49332 --- aio/content/examples/upgrade-module/BUILD.bazel | 6 +++++- aio/content/examples/upgrade-phonecat-2-hybrid/BUILD.bazel | 6 +++++- aio/content/examples/upgrade-phonecat-3-final/BUILD.bazel | 1 + aio/package.json | 6 +++--- 4 files changed, 14 insertions(+), 5 deletions(-) diff --git a/aio/content/examples/upgrade-module/BUILD.bazel b/aio/content/examples/upgrade-module/BUILD.bazel index 19bd04f2a90..0c13cff305b 100644 --- a/aio/content/examples/upgrade-module/BUILD.bazel +++ b/aio/content/examples/upgrade-module/BUILD.bazel @@ -8,5 +8,9 @@ docs_example( flaky = True, # TODO: figure out why this is flaky or times out # This example downloads and inlines resources test_exec_properties = ENABLE_NETWORK, - test_tags = ["requires-network"], + test_tags = [ + "requires-network", + # This is currently broken due to usage of ESM2022 which does not work out-of-the-box with system.js. + "broken", + ], ) diff --git a/aio/content/examples/upgrade-phonecat-2-hybrid/BUILD.bazel b/aio/content/examples/upgrade-phonecat-2-hybrid/BUILD.bazel index 18ff1e776fe..7685052b87b 100644 --- a/aio/content/examples/upgrade-phonecat-2-hybrid/BUILD.bazel +++ b/aio/content/examples/upgrade-phonecat-2-hybrid/BUILD.bazel @@ -8,5 +8,9 @@ docs_example( flaky = True, # TODO: figure out why this is flaky or times out # This example downloads and inlines resources test_exec_properties = ENABLE_NETWORK, - test_tags = ["requires-network"], + test_tags = [ + "requires-network", + # This is currently broken due to usage of ESM2022 which does not work out-of-the-box with system.js. + "broken", + ], ) diff --git a/aio/content/examples/upgrade-phonecat-3-final/BUILD.bazel b/aio/content/examples/upgrade-phonecat-3-final/BUILD.bazel index ffefa1698cd..a6d2ecfe030 100644 --- a/aio/content/examples/upgrade-phonecat-3-final/BUILD.bazel +++ b/aio/content/examples/upgrade-phonecat-3-final/BUILD.bazel @@ -5,4 +5,5 @@ package(default_visibility = ["//visibility:public"]) docs_example( name = "upgrade-phonecat-3-final", flaky = True, # TODO: figure out why this is flaky or times out + test_tags = ["broken"], # This is currently broken due to usage of ESM2022 which does not work out-of-the-box with system.js. ) diff --git a/aio/package.json b/aio/package.json index 1fe49936aca..e120ea2083d 100644 --- a/aio/package.json +++ b/aio/package.json @@ -12,10 +12,10 @@ "build-prod": "yarn build --config=release", "build-local": "yarn build --config=aio_local_deps", "lint": "yarn check-env && yarn docs-lint && ng lint && yarn example-lint && yarn tools-lint && yarn security-lint", - "test": "bazel test //aio:test --test_output=streamed", - "test-and-watch": "ibazel test //aio:test-and-watch --test_output=streamed", + "test": "bazel test //aio:test --test_output=streamed --test_tag_filters=-broken", + "test-and-watch": "ibazel test //aio:test-and-watch --test_output=streamed --test_tag_filters=-broken", "test-local": "yarn test --config=aio_local_deps", - "test:ci": "bazel test //aio/...", + "test:ci": "bazel test //aio/... --test_tag_filters=-broken", "test-local:ci": "yarn test:ci --config=aio_local_deps", "e2e": "bazel test //aio:e2e", "e2e-local": "yarn e2e --config=aio_local_deps",